From a127f6d0f284eaf4f0fd994bf138fd1d50b0d777 Mon Sep 17 00:00:00 2001
From: Martin Nolte <nolte@mathematik.uni-freiburg.de>
Date: Mon, 4 Dec 2017 11:32:24 +0100
Subject: [PATCH] [cmake][python] use `pip --upgrade` on install
This patch will always upgrade the Python package upon `make install`.
Previously, the Python package was only installed, if the package had not
been installed before. This violates the principle of least surprise as we
intuitively except `make install` to overwrite all files during the install
procedure.
---
cmake/modules/DunePythonInstallPackage.cmake | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cmake/modules/DunePythonInstallPackage.cmake b/cmake/modules/DunePythonInstallPackage.cmake
index 97f9c1ab2..297d45906 100644
--- a/cmake/modules/DunePythonInstallPackage.cmake
+++ b/cmake/modules/DunePythonInstallPackage.cmake
@@ -84,7 +84,7 @@ function(dune_python_install_package)
endif()
set(INSTALL_CMDLINE -m pip install
- "${INSTALL_OPTION}" "${WHEEL_OPTION}" "${EDIT_OPTION}" ${PYINST_ADDITIONAL_PIP_PARAMS}
+ "${INSTALL_OPTION}" --upgrade "${WHEEL_OPTION}" "${EDIT_OPTION}" ${PYINST_ADDITIONAL_PIP_PARAMS}
"${PYINST_FULLPATH}")
--
GitLab