1. 06 Oct, 2016 1 commit
    • Oliver Sander's avatar
      Implement the subIndex method for entities of all dimensions · e33c2731
      Oliver Sander authored
      Previously, it was available only for elements.
      
      The following question appears: what does the codim-parameter in
      
        template<int cc>
        unsigned int subIndex (const Codim<cc>::Entity& e,
                               int i,
                               unsigned int codim) const
      
      mean?  Is it the codimension wrt to the grid, or wrt to the entity e?
      I did not find this documented anywhere, and therefore made my own
      choice.  The 'codim' in this patch is the codimension with respect
      to the *grid*.
      e33c2731
  2. 30 Sep, 2016 1 commit
  3. 29 Sep, 2016 3 commits
  4. 27 Sep, 2016 3 commits
  5. 20 Sep, 2016 1 commit
  6. 19 Sep, 2016 3 commits
  7. 16 Sep, 2016 2 commits
  8. 14 Sep, 2016 1 commit
    • Martin Nolte's avatar
      [bugfix] make subIndex method for OneDGrid compile for all codimension · fff8fbc6
      Martin Nolte authored
      The index sets of OneDGrid support the subIndex method for entities of
      all codimensions. However, while the code was semantically correct for
      the case "cc != 0", the compiler would try to compile the "cc == 0"
      branch, too. This caused a compile-time error.
      
      This patch fixes the issue by calling a separate method for each
      codimension.
      fff8fbc6
  9. 06 Sep, 2016 1 commit
    • Oliver Sander's avatar
      Merge branch 'feature/convert-fixedsize-to-camelcase' into 'master' · b076b05d
      Oliver Sander authored
      CommDataHandleIF: Introduce method 'fixedSize', which does the same as 'fixedsize', but has camel-case naming
      
         The CommDataHandleIF interface class has a member 'fixedsize'.  This is one
          of the few in dune-grid that does not comply with the official naming rules:
          the name should be 'fixedSize'.  This patch introduces a new method 'fixedSize',
          to allow a gradual transition from the old spelling to the new one.
          The make the transition as painless as possible, but methods implement the
          following behavior (remember that CommDataHandleIF is the base class in a
          CRTP pattern):
          
          - If the derived/implementation class has a method 'fixedSize', then that
            method is called.
          - Otherwise, the method 'fixedsize' is called.
          
          This approach allows both implementors of grids and implementors of data
          handles to switch their code from 'fixedsize' to 'fixedSize' at their
          convenience.
          
          Finally, I have come across a usecase for CRTP. :-)
      
      
      See merge request !82
      b076b05d
  10. 05 Sep, 2016 2 commits
  11. 31 Aug, 2016 3 commits
    • Oliver Sander's avatar
      [bugfix] Properly implement entity seeds for UGGrid facets and edges · 6bf969bd
      Oliver Sander authored
      Due to unclear semantics of the hasEntity capability, these case are not
      currently tested by the checkentityseed.hh grid test.
      6bf969bd
    • Oliver Sander's avatar
      Use getter method getTarget, instead of using member data 'target_' directly · afc9237e
      Oliver Sander authored
      That's what the getter is for, and the target_ member is protected in some of the
      specializations of UGGridEntity.
      afc9237e
    • Oliver Sander's avatar
      Simplification: merge the two classes that implement element facets in 3d into one · 5f43cf3f
      Oliver Sander authored
      Previously, the implementation of UGGrid entities for facets of 3d elements
      consisted of two classes: UGGridEntity<1,3>, a specialization of the generic
      implementation class for UGGrid entities, and UGFaceEntity, a special
      implementation class for the codim-1 case in 3d.  There was never a real
      reason for this separation into two classes, and this patch does away
      with it.  This leads to a minor code simplification.
      
      Note: The same separation into two classes holds for grid edges, and there is
      a reason.  The UGEdgeEntity class, which contains the actual implementation,
      serves for *two* cases: UGGridEntity<1,2> and UGGridEntity<2,3>.
      C++ partial specialization rules apparently do not allow to merge all of this
      into one class.
      5f43cf3f
  12. 18 Aug, 2016 2 commits
  13. 17 Aug, 2016 1 commit
  14. 15 Aug, 2016 2 commits
    • Oliver Sander's avatar
    • Oliver Sander's avatar
      Introduce method 'fixedSize', which does the same as 'fixedsize', but has camel-case naming · 08c28d55
      Oliver Sander authored
      The CommDataHandleIF interface class has a member 'fixedsize'.  This is one
      of the few in dune-grid that does not comply with the official naming rules:
      the name should be 'fixedSize'.  This patch introduces a new method 'fixedSize',
      to allow a gradual transition from the old spelling to the new one.
      The make the transition as painless as possible, but methods implement the
      following behavior (remember that CommDataHandleIF is the base class in a
      CRTP pattern):
      
      - If the derived/implementation class has a method 'fixedSize', then that
        method is called.
      - Otherwise, the method 'fixedsize' is called.
      
      This approach allows both implementors of grids and implementors of data
      handles to switch their code from 'fixedsize' to 'fixedSize' at their
      convenience.
      
      Finally, I have come across a usecase for CRTP. :-)
      08c28d55
  15. 12 Aug, 2016 2 commits
  16. 11 Aug, 2016 1 commit
  17. 10 Aug, 2016 2 commits
  18. 09 Aug, 2016 4 commits
  19. 07 Aug, 2016 1 commit
  20. 05 Aug, 2016 4 commits