dune-grid merge requestshttps://gitlab.dune-project.org/core/dune-grid/-/merge_requests2016-10-25T17:37:42Zhttps://gitlab.dune-project.org/core/dune-grid/-/merge_requests/113Do not force grids to subclass Entity or Geometry2016-10-25T17:37:42ZMarkus BlattDo not force grids to subclass Entity or GeometryThe current implementation assumes that both the Entity and the Geometry of a grid are subclasses of Dune::Entity and Dune::Geometry. This requirement must have been introduced after 2.4.1 and is IMHO to much of restriction. After all th...The current implementation assumes that both the Entity and the Geometry of a grid are subclasses of Dune::Entity and Dune::Geometry. This requirement must have been introduced after 2.4.1 and is IMHO to much of restriction. After all these are just tests. With this MR we drop this additional restriction. Tested with opm-grid.
Closes #36DUNE 2.5.0https://gitlab.dune-project.org/core/dune-grid/-/merge_requests/93WIP: Implement the subIndex method for entities of all dimensions2016-10-13T21:16:46ZOliver Sanderoliver.sander@tu-dresden.deWIP: Implement the subIndex method for entities of all dimensionsPreviously, it was available only for elements.
This merge request makes the strengthened test from !89 compile, therefore partially fixing #25 .
The test will not run yet, because a few cases are still stubs.
The following question ap...Previously, it was available only for elements.
This merge request makes the strengthened test from !89 compile, therefore partially fixing #25 .
The test will not run yet, because a few cases are still stubs.
The following question appears: what does the codim-parameter in
template<int cc>
unsigned int subIndex (const Codim<cc>::Entity& e,
int i,
unsigned int codim) const
mean? Is it the codimension wrt to the grid, or wrt to the entity e?
I did not find this documented anywhere, and therefore made my own
choice. The 'codim' in this patch is the codimension with respect
to the *grid*.DUNE 2.5.0https://gitlab.dune-project.org/core/dune-grid/-/merge_requests/89Simplify static check for higher codimension information on grid views2016-10-14T14:09:51ZCarsten Gräsergraeser@math.fau.deSimplify static check for higher codimension information on grid viewsThis is a follow-up request to !87 implementing the simplified codim loop with `Hybrid::forEach()` as proposed by @oliver.sander.
This also merges the two codim loops and extends the check for `gv.indexSet().types(codim)` to the previous...This is a follow-up request to !87 implementing the simplified codim loop with `Hybrid::forEach()` as proposed by @oliver.sander.
This also merges the two codim loops and extends the check for `gv.indexSet().types(codim)` to the previously missing case `codim==dimension`.DUNE 2.5.0https://gitlab.dune-project.org/core/dune-grid/-/merge_requests/87[test] add static check for higher codimension information on grid views2016-10-14T14:09:24ZMartin Nolte[test] add static check for higher codimension information on grid viewsUntil now, the static part of the grid check only check on codim 0 structures,
e.g., on the index set. This patch also performs these checks on higher
codimensions.
For the IndexSet::subIndex method, it will only check whether the metho...Until now, the static part of the grid check only check on codim 0 structures,
e.g., on the index set. This patch also performs these checks on higher
codimensions.
For the IndexSet::subIndex method, it will only check whether the method
compiles. If codim > 0, it will silently ignore a Dune::NotImplemented
exception, so that grids are not forced to implement the method; it simply has
to compile.
Note: This check is able to detect the error fix in !86.DUNE 2.5.0