Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
  • Sign in
D
dune-alugrid
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 2
    • Issues 2
    • List
    • Boards
    • Labels
    • Milestones
  • Merge Requests 2
    • Merge Requests 2
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • extensions
  • dune-alugrid
  • Merge Requests
  • !69

Merged
Opened Apr 03, 2019 by Stephan Hilb@stephan.hilb
  • Report abuse
Report abuse

gitter: fix method signature

there does not seem to be any call to the method with one argument and the virtual method in gitter_sti.h demands three arguments. Silences this compiler warning:

warning: 'ALUGrid::GitterBasis::Objects::TetraEmpty::changeVertexCoordinates' hides overloaded virtual function [-Woverloaded-virtual]

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch "https://gitlab.dune-project.org/stephan.hilb/dune-alugrid.git" "fix-warnings"
git checkout -b "stephan.hilb/dune-alugrid-fix-warnings" FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout "origin/master"
git merge --no-ff "stephan.hilb/dune-alugrid-fix-warnings"

Step 4. Push the result of the merge to GitLab

git push origin "master"

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

  • Discussion 3
  • Commits 2
  • Pipelines 2
  • Changes 1
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View project labels
Reference: extensions/dune-alugrid!69

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.