FS issueshttps://gitlab.dune-project.org/flyspray/FS/-/issues2015-06-17T09:07:55Zhttps://gitlab.dune-project.org/flyspray/FS/-/issues/1648FS#1648 [CMake] Dont build modules when CMAKE_DISABLE_FIND_PACKAGE_<mod> is set.2015-06-17T09:07:55ZDominic Kempfdominic.kempf@iwr.uni-heidelberg.deFS#1648 [CMake] Dont build modules when CMAKE_DISABLE_FIND_PACKAGE_<mod> is set.
# Metadata
| Property | Value |
| -------- | ----- |
| Reported by | Dominic Kempf (dominic.r.kempf@gmail.com) |
| Reported at | May 11, 2015 16:14 |
| Type | Feature Request |
| Version | 2.3 |
| Operating System | Unspecified ...
# Metadata
| Property | Value |
| -------- | ----- |
| Reported by | Dominic Kempf (dominic.r.kempf@gmail.com) |
| Reported at | May 11, 2015 16:14 |
| Type | Feature Request |
| Version | 2.3 |
| Operating System | Unspecified / All |
| Last edited by | Dominic Kempf (dominic.r.kempf@gmail.com) |
| Last edited at | Jun 17, 2015 09:07 |
| Closed by | Dominic Kempf (dominic.r.kempf@gmail.com) |
| Closed at | Jun 17, 2015 09:07 |
| Closed in version | Unknown |
| Resolution | Implemented |
| Comment | |
# Description
CMakes mechanism of suppressing the detection of an external package does work for dune modules too. I find it quite handy to write the following line into my opts file:
CMAKE_FLAGS += '-DCMAKE_DISABLE_FIND_PACKAGE_dune-alugrid=1'
This results in dune-pdelab not looking for dune-alugrid (which is only suggested, not required) and could speed up my builds greatly, if not...
However, the module dune-alugrid itself is still build. I would like to add a check to the build system that checks whether the given module itself has been disabled and skip the building process in that case. I do not know yet, where such option would ideally be hooked in.
https://gitlab.dune-project.org/flyspray/FS/-/issues/1647FS#1647 duneproject choice about package enablement doesn't work2015-05-12T10:02:17ZOliver Sanderoliver.sander@tu-dresden.deFS#1647 duneproject choice about package enablement doesn't work
# Metadata
| Property | Value |
| -------- | ----- |
| Reported by | Oliver Sander (oliver.sander@tu-dresden.de) |
| Reported at | May 11, 2015 09:20 |
| Type | Bug Report |
| Version | 2.3 |
| Operating System | Unspecified / A...
# Metadata
| Property | Value |
| -------- | ----- |
| Reported by | Oliver Sander (oliver.sander@tu-dresden.de) |
| Reported at | May 11, 2015 09:20 |
| Type | Bug Report |
| Version | 2.3 |
| Operating System | Unspecified / All |
| Last edited by | Oliver Sander (oliver.sander@tu-dresden.de) |
| Last edited at | May 12, 2015 10:02 |
| Closed by | Oliver Sander (oliver.sander@tu-dresden.de) |
| Closed at | May 12, 2015 10:02 |
| Closed in version | Unknown |
| Resolution | Fixed |
| Comment | 20ac0ea1a440e98cd4863872d3c6f9699dfb88f6 |
# Description
duneproject recently started to ask whether all packages should be enabled. However, it will only accept 'yes' for an answer. See the test run below.
Further worries:
- No non-developer is going to understand what the question means.
- If, as is says, 'WE' strongly suggest yes, then 'yes' should be the default.
~/dune-adaptivity> ~/dune/dune-common/bin/duneproject
== Dune project/module generator ==
duneproject will assist you in the creation of a new Dune application.
During this process a new directory with the name of your project will be
created. This directory will hold all configuration and Makefiles and a
simple example application.
1) Name of your new Project? (e.g.: dune-grid): dune-foo
2) Which modules should this module depend on?
Following modules are found:
dune-common dune-geometry dune-grid dune-istl dune-localfunctions dune-grid-glue dune-typetree dune-pdelab
Enter space separated list: dune-grid
3) Project/Module version? 1.0
4) Maintainer's email address? sander@igpm.rwth-aachen.de
5) Enable all found packages? (WE strongly recommend yes, unless you know exactly what you are doing) [y/N]n
5) Enable all found packages? (WE strongly recommend yes, unless you know exactly what you are doing) [y/N]N
5) Enable all found packages? (WE strongly recommend yes, unless you know exactly what you are doing) [y/N]y
creating Project "dune-foo", version 1.0
which depends on "dune-grid"
with maintainer "sander@igpm.rwth-aachen.de"
Are these informations correct? [y/N]
https://gitlab.dune-project.org/flyspray/FS/-/issues/1646FS#1646 GridTraits: IndexType for IndexSets hardcoded to default value2017-08-26T20:11:54ZAnsgar Burchardtansgar.burchardt@tu-dresden.deFS#1646 GridTraits: IndexType for IndexSets hardcoded to default value# Metadata
| Property | Value |
| -------- | ----- |
| Reported by | Ansgar Burchardt (burchardt@igpm.rwth-aachen.de) |
| Reported at | May 8, 2015 15:10 |
| Type | Bug Report |
| Version | Git (pre2.4) [autotools] |
| Op...# Metadata
| Property | Value |
| -------- | ----- |
| Reported by | Ansgar Burchardt (burchardt@igpm.rwth-aachen.de) |
| Reported at | May 8, 2015 15:10 |
| Type | Bug Report |
| Version | Git (pre2.4) [autotools] |
| Operating System | Unspecified / All |
# Description
The GridTraits traits class contains the following typedef:
```
typedef IndexSet<const GridImp,LevelIndexSetImp> LevelIndexSet;
```
This hardcodes the 3rd and 4th template parameters for `IndexSet` to its default values:
```
template< class GridImp, class IndexSetImp, class IndexTypeImp = unsigned int, class TypesImp = std::vector< GeometryType > > class IndexSet;
```
UG makes use of this: if defines `IndexTypeImp` to `UG::INT`. This works as long as `unsigned int` and `UG::INT` are compatible; this is not the case on the ppc64el architecture.
I see several options:
1. Require `IndexTypeImp` to *always* be `unsigned int`. Not sure what this means for UG.
2. Add additional template parameters for `IndexTypeImp` and `TypesImp` to the `GridTraits` class, with default parameters. This would extend the grid interface, but be backwards-compatible. Raises the question if `Leaf-` and `LevelIndexSet` need to have the same `IndexType` or not.
3. Let grid implementations pass the full `IndexSet<...>` type instead of just the implementation. This is certainly not backwards compatible.
Ansgar
https://gitlab.dune-project.org/flyspray/FS/-/issues/1645FS#1645 Construction a nonconforming cube dune-alugrid from alu file fails2015-05-08T14:17:04ZDominic Kempfdominic.kempf@iwr.uni-heidelberg.deFS#1645 Construction a nonconforming cube dune-alugrid from alu file fails
# Metadata
| Property | Value |
| -------- | ----- |
| Reported by | Dominic Kempf (dominic.r.kempf@gmail.com) |
| Reported at | May 8, 2015 14:07 |
| Type | Bug Report |
| Version | 2.3 |
| Operating System | Unspecified / All ...
# Metadata
| Property | Value |
| -------- | ----- |
| Reported by | Dominic Kempf (dominic.r.kempf@gmail.com) |
| Reported at | May 8, 2015 14:07 |
| Type | Bug Report |
| Version | 2.3 |
| Operating System | Unspecified / All |
| Last edited by | Dominic Kempf (dominic.r.kempf@gmail.com) |
| Last edited at | May 8, 2015 14:17 |
| Closed by | Dominic Kempf (dominic.r.kempf@gmail.com) |
| Closed at | May 8, 2015 14:17 |
| Closed in version | Unknown |
| Resolution | Not a bug |
| Comment | |
# Description
Porting the dune-pdelab-howto the next issue, that came up is, that I have attached alufile, which dune-alugrid fails to construct a grid from with mysterious reasons:
ERROR: ALUGrid signature (!ALU) not found.
ERROR (fatal): Unable to read macro grid header.
Adding the signature !ALU will on the other hand produces the following error:
Delivered file '3drefinedcube.alu' does not contain keyword '!Hexahedra'. Found id '!ALU'. Check the macro grid file! Bye.
I digged a bit through the code base and it seems like there are two separate pieces of code which expect the first line of the input to be of a specific form.
# Attachments
* [3drefinedcube.alu](/uploads/ab5a86b15780135c7efaed29f0e16c41/3drefinedcube.alu)
https://gitlab.dune-project.org/flyspray/FS/-/issues/1644FS#1644 bigunsignedint: ambiguous overload for bigunsignedint(unsigned long)2015-05-11T17:21:44ZAnsgar Burchardtansgar.burchardt@tu-dresden.deFS#1644 bigunsignedint: ambiguous overload for bigunsignedint(unsigned long)
# Metadata
| Property | Value |
| -------- | ----- |
| Reported by | Ansgar Burchardt (burchardt@igpm.rwth-aachen.de) |
| Reported at | May 8, 2015 13:18 |
| Type | Bug Report |
| Version | Git (pre2.4) [autotools] |
| Operating...
# Metadata
| Property | Value |
| -------- | ----- |
| Reported by | Ansgar Burchardt (burchardt@igpm.rwth-aachen.de) |
| Reported at | May 8, 2015 13:18 |
| Type | Bug Report |
| Version | Git (pre2.4) [autotools] |
| Operating System | Unspecified / All |
| Last edited by | Steffen Müthing (steffen.muething@iwr.uni-heidelberg.de) |
| Last edited at | May 11, 2015 17:21 |
| Closed by | Steffen Müthing (steffen.muething@iwr.uni-heidelberg.de) |
| Closed at | May 11, 2015 17:21 |
| Closed in version | Unknown |
| Resolution | Fixed |
| Comment | Merged to master in 4c79a64 and backported to release branch in b0287a9.
Thanks, Ansgar! |
# Description
The following code from YaspGrid fails to compile on i386 where size_t == int == int32_t, unsigned long == uint64_t:
+---
| dune/grid/yaspgrid/yaspgridentity.hh:338:52: error: call of overloaded 'bigunsignedint(long unsigned int)' is ambiguous
| PersistentIndexType id(_it.shift().to_ulong());
+---[ https://buildd.debian.org/status/fetch.php?pkg=dune-grid&arch=i386&ver=2.4~20150506gd3c1350-1&stamp=1431044142 ]
PersistentIndexType is Dune::bigunsignedint<80> which has two constructors that could be called:
* bigunsignedint(std::size_t x) (== unsigned int)
* bigunsignedint(int y)
Both involve converting the "unsigned long" to a shorter type -> ambiguous overload.
I also noticed that the constructor taking an "int" does (for me) unexpected things:
+---
| template<int k>
| bigunsignedint<k>::bigunsignedint (int y)
| {
| std::size_t x = std::abs(y);
| assign(x);
| }
+---
I really wouldn't expect "bigunsignedint(-42)" to be equivalent to "bigunsignedint(42)"...
I would like to replace the constructor taking an "size_t" with one taking "uintmax_t" (since C++11, though C introduced it earlier). I also think the constructor taking an "int" should be deprecated.
As an unrelated change I would like to replace "unsigned short" with "uint16_t" in this class (also a C++11 type). (C++ doesn't require "unsigned short" to be "uint16_t", but the code here does.)
Ansgar
https://gitlab.dune-project.org/flyspray/FS/-/issues/1643FS#1643 dune-alugrid should use static assertions to prevent use of non-confo...2017-08-26T20:11:54ZDominic Kempfdominic.kempf@iwr.uni-heidelberg.deFS#1643 dune-alugrid should use static assertions to prevent use of non-conforming cube grids.# Metadata
| Property | Value |
| -------- | ----- |
| Reported by | Dominic Kempf (dominic.r.kempf@gmail.com) |
| Reported at | May 8, 2015 11:59 |
| Type | Bug Report |
| Version | Git (pre2.4) [cmake] |
| Operating Sys...# Metadata
| Property | Value |
| -------- | ----- |
| Reported by | Dominic Kempf (dominic.r.kempf@gmail.com) |
| Reported at | May 8, 2015 11:59 |
| Type | Bug Report |
| Version | Git (pre2.4) [cmake] |
| Operating System | Unspecified / All |
| Last edited by | Robert K (robertk@posteo.org) |
| Last edited at | Jul 21, 2015 15:20 |
# Description
Dear dune-alugrid developers, please checkout the following minimum example:
http://conan2.iwr.uni-heidelberg.de/git/snippets/2
This compiles fine and gets through the factory process, but seems to be stuck in an infinite loop when trying to do the global refinement.
Tested on Ubuntu 14.04, g++ 4.8.2
EDIT: Changed title to reflect actual problem.
https://gitlab.dune-project.org/flyspray/FS/-/issues/1642FS#1642 Make it possible to skip the BoundarySegmentIndex tests in gridcheck2015-05-08T11:35:38ZSteffen Müthingsteffen.muething@iwr.uni-heidelberg.deFS#1642 Make it possible to skip the BoundarySegmentIndex tests in gridcheck
# Metadata
| Property | Value |
| -------- | ----- |
| Reported by | Steffen Müthing (steffen.muething@iwr.uni-heidelberg.de) |
| Reported at | May 7, 2015 21:34 |
| Type | Feature Request |
| Version | Git (pre2.4) [cmake] |
| ...
# Metadata
| Property | Value |
| -------- | ----- |
| Reported by | Steffen Müthing (steffen.muething@iwr.uni-heidelberg.de) |
| Reported at | May 7, 2015 21:34 |
| Type | Feature Request |
| Version | Git (pre2.4) [cmake] |
| Operating System | Unspecified / All |
| Last edited by | Steffen Müthing (steffen.muething@iwr.uni-heidelberg.de) |
| Last edited at | May 8, 2015 11:35 |
| Closed by | Steffen Müthing (steffen.muething@iwr.uni-heidelberg.de) |
| Closed at | May 8, 2015 11:35 |
| Closed in version | 2.4 |
| Resolution | Implemented |
| Comment | Merged to master and backported to release
master: e2f9c21
releases/2.4: 99059c5 |
# Description
I'd like to be able to skip the BoundarySegmentIndex tests in the gridcheck because that would allow me to run it on the subdomain grids of MultiDomainGrid without failing.
The subdomains simply forward the BoundarySegmentIndex of the host grid, which is of course not correct and trips the test, but I don't even expect that data to be correct for the subdomains.
I'd suggest adding a struct that can be specialized similar to how EnableLevelIntersectionIteratorCheck works now. I'll post a comment with an example implementation to a feature branch.
https://gitlab.dune-project.org/flyspray/FS/-/issues/1641FS#1641 Disable Fortran detection in dune-common2015-05-14T05:35:57ZFlyspray ImporterFS#1641 Disable Fortran detection in dune-common
# Metadata
| Property | Value |
| -------- | ----- |
| Reported by | Timo Betcke (timo.betcke@gmail.com) |
| Reported at | May 7, 2015 13:08 |
| Type | Bug Report |
| Version | 2.3 |
| Operating System | Unspecified / All |
| La...
# Metadata
| Property | Value |
| -------- | ----- |
| Reported by | Timo Betcke (timo.betcke@gmail.com) |
| Reported at | May 7, 2015 13:08 |
| Type | Bug Report |
| Version | 2.3 |
| Operating System | Unspecified / All |
| Last edited by | Christoph Grüninger (gruenich@iws.uni-stuttgart.de) |
| Last edited at | May 14, 2015 05:35 |
| Closed by | Christoph Grüninger (gruenich@iws.uni-stuttgart.de) |
| Closed at | May 14, 2015 05:35 |
| Closed in version | Unknown |
| Resolution | Fixed |
| Comment | I backported the changes to Dune 2.3. |
# Description
The attached patch disables Fortran detection in CMake. This is important on systems without Fortran Compiler (e.g. Mac) where otherwise CMake would fail.
Best wishes
Timo
# Attachments
* [dune_disable_fortran.patch](/uploads/9eb4f9274667c4ce196dc649a29fd9ec/dune_disable_fortran.patch)
https://gitlab.dune-project.org/flyspray/FS/-/issues/1640FS#1640 Alugrid repository has a very large size due to git history2015-11-20T08:32:54ZFlyspray ImporterFS#1640 Alugrid repository has a very large size due to git history
# Metadata
| Property | Value |
| -------- | ----- |
| Reported by | Timo Betcke (timo.betcke@gmail.com) |
| Reported at | May 7, 2015 13:05 |
| Type | Bug Report |
| Version | 2.3 |
| Operating System | Unspecified / All |
# D...
# Metadata
| Property | Value |
| -------- | ----- |
| Reported by | Timo Betcke (timo.betcke@gmail.com) |
| Reported at | May 7, 2015 13:05 |
| Type | Bug Report |
| Version | 2.3 |
| Operating System | Unspecified / All |
# Description
The size of the Alugrid repository is almost 100 MB. Deleting the git history brings this down to 11MB. This is due to some old data files being present in the git history. Could this be fixed? It is inconvenient to download Alugrid as part of an installer due to the excessive file size of the repository.
Best wishes
Timo
https://gitlab.dune-project.org/flyspray/FS/-/issues/1639FS#1639 Data Type conversion bug in dune-localfunctions2015-05-09T08:47:31ZFlyspray ImporterFS#1639 Data Type conversion bug in dune-localfunctions
# Metadata
| Property | Value |
| -------- | ----- |
| Reported by | Timo Betcke (timo.betcke@gmail.com) |
| Reported at | May 7, 2015 12:58 |
| Type | Bug Report |
| Version | 2.3 |
| Operating System | Unspecified / All |
| La...
# Metadata
| Property | Value |
| -------- | ----- |
| Reported by | Timo Betcke (timo.betcke@gmail.com) |
| Reported at | May 7, 2015 12:58 |
| Type | Bug Report |
| Version | 2.3 |
| Operating System | Unspecified / All |
| Last edited by | Oliver Sander (oliver.sander@tu-dresden.de) |
| Last edited at | May 9, 2015 08:47 |
| Closed by | Oliver Sander (oliver.sander@tu-dresden.de) |
| Closed at | May 9, 2015 08:47 |
| Closed in version | Unknown |
| Resolution | Fixed |
| Comment | dune-localfunctions commit 727cc72dc550a7ae1aa71abd134983abe324575a
|
# Description
Dear All,
we encountered an issue in dune-localfunctions. An example is the command
product *= 1.0/(pos[i]-pos[alpha]);
in lagrange/pk2d/pk2dlocalbasis.hh. If pos is a an array of type complex<float> a compiler error appears since 1.0 is a double and multiplication of complex<float> with double is not defined.
This can be easily fixed by changing it to
product *= D(1)/(pos[i]-pos[alpha]);
which converts the 1 into the correct data type.
The attached patch fixes the problem in pk2dlocalbasis.hh and raviartthomas02dlocalbasis.hh. It is well possible that other files are also effected. But we can't test as they are not used in our codes.
Best wishes
Timo
# Attachments
* [dune_localfunctions.patch](/uploads/3d8ba6030975550e4beb0af8a0945e93/dune_localfunctions.patch)
https://gitlab.dune-project.org/flyspray/FS/-/issues/1638FS#1638 Patches for Alugrid CMake Files2015-06-29T13:46:50ZFlyspray ImporterFS#1638 Patches for Alugrid CMake Files
# Metadata
| Property | Value |
| -------- | ----- |
| Reported by | Timo Betcke (timo.betcke@gmail.com) |
| Reported at | May 7, 2015 12:52 |
| Type | External Bug |
| Version | 2.3 |
| Operating System | Unspecified / All |
| ...
# Metadata
| Property | Value |
| -------- | ----- |
| Reported by | Timo Betcke (timo.betcke@gmail.com) |
| Reported at | May 7, 2015 12:52 |
| Type | External Bug |
| Version | 2.3 |
| Operating System | Unspecified / All |
| Last edited by | Christoph Grüninger (gruenich@iws.uni-stuttgart.de) |
| Last edited at | Jun 29, 2015 13:46 |
| Closed by | Christoph Grüninger (gruenich@iws.uni-stuttgart.de) |
| Closed at | Jun 29, 2015 13:46 |
| Closed in version | Unknown |
| Resolution | Fixed |
| Comment | Thanks for the patch; committed to dune-alugrid master. If there are issues to discuss, use the according issue in the dune-alugrid issue tracker http://users.dune-project.org/issues/313 |
# Description
Dear All,
I have created patches for the current revision of the Alugrid development version
(Revision 95c07ef8c80c2ea6f19c441eedf997507e40cde4)
These fix a couple of bugs in the CMake build scripts that I encountered when building Alugrid on Mac with CMake. Without this patch CMake fails building Alugrid on Mac. All bugs relate to files not being copied at all or not being copied to the correct location when 'make install' is run. Without the patch 'make install' exits with an error message and never fully executes on Mac.
The patch file is attached.
Best wishes
Timo
# Attachments
* [alugrid_cmake.patch](/uploads/722b86e683f2c3e830629a97d8796d36/alugrid_cmake.patch)
https://gitlab.dune-project.org/flyspray/FS/-/issues/1637FS#1637 Homebrew recipies for DUNE2015-05-25T18:20:28ZFlyspray ImporterFS#1637 Homebrew recipies for DUNE
# Metadata
| Property | Value |
| -------- | ----- |
| Reported by | Timo Betcke (timo.betcke@gmail.com) |
| Reported at | May 7, 2015 08:57 |
| Type | Discussion |
| Version | 2.3 |
| Operating System | Unspecified / All |
| La...
# Metadata
| Property | Value |
| -------- | ----- |
| Reported by | Timo Betcke (timo.betcke@gmail.com) |
| Reported at | May 7, 2015 08:57 |
| Type | Discussion |
| Version | 2.3 |
| Operating System | Unspecified / All |
| Last edited by | Oliver Sander (oliver.sander@tu-dresden.de) |
| Last edited at | May 25, 2015 18:20 |
| Closed by | Oliver Sander (oliver.sander@tu-dresden.de) |
| Closed at | May 25, 2015 18:20 |
| Closed in version | Unknown |
| Resolution | Fixed |
| Comment | Added Timo's text to the main download page. Thanks again! |
# Description
Dear All,
I have made Homebrew recipes available to easily install DUNE on Mac. These can be accessed via
brew tap bempp/homebrew-bempp
and then
brew install dune-common
brew install dune-grid
etc...
The repository is at:
https://github.com/bempp/homebrew-bempp
A couple of notes:
- They are relatively basic in the sense that I am not allowing options to be passed on and rely on CMake detecting everything. This was sufficient for our purpose but may not be enough for others.
- I still needed to include the patches already proposed in FS#1480 for Mac. Otherwise, there are linking issues on Mac.
- We also have to patch dune-localfunctions due to an issue with complex data types. I will open a separate bug issue for this.
- Alugrid is currently installed from a tarball that we created from our own repository. I will make patches available for the Dune alugrid repository separately. We had some issues with the size of the Alugrid repository due to some old data files being present in its git history. I communicated this already to Andreas Dedner.
If there is any interest from your side feel free to copy the Homebrew recipes and make them available for others.
Best wishes
Timo
https://gitlab.dune-project.org/flyspray/FS/-/issues/1636FS#1636 formatString: not thread-safe (static char buffer[])2015-05-06T16:41:44ZAnsgar Burchardtansgar.burchardt@tu-dresden.deFS#1636 formatString: not thread-safe (static char buffer[])
# Metadata
| Property | Value |
| -------- | ----- |
| Reported by | Ansgar Burchardt (burchardt@igpm.rwth-aachen.de) |
| Reported at | May 6, 2015 13:45 |
| Type | Bug Report |
| Version | Git (pre2.4) [autotools] |
| Operating...
# Metadata
| Property | Value |
| -------- | ----- |
| Reported by | Ansgar Burchardt (burchardt@igpm.rwth-aachen.de) |
| Reported at | May 6, 2015 13:45 |
| Type | Bug Report |
| Version | Git (pre2.4) [autotools] |
| Operating System | Unspecified / All |
| Last edited by | Ansgar Burchardt (burchardt@igpm.rwth-aachen.de) |
| Last edited at | May 6, 2015 16:41 |
| Closed by | Ansgar Burchardt (burchardt@igpm.rwth-aachen.de) |
| Closed at | May 6, 2015 16:41 |
| Closed in version | Unknown |
| Resolution | Fixed |
| Comment | |
# Description
The formatString() function uses static buffer which makes it not safe to use in multiple threads. The attached patch moves the buffer to the stack which is not shared between threads.
Ansgar
# Attachments
* [0001-Move-buffer-variable-to-automatic-storage.patch](/uploads/778d5edd88ccd6e5c0329191e983c62b/0001-Move-buffer-variable-to-automatic-storage.patch)
https://gitlab.dune-project.org/flyspray/FS/-/issues/1635FS#1635 tuples.hh: use variadic templates for in- and output operators2015-05-06T12:09:47ZAnsgar Burchardtansgar.burchardt@tu-dresden.deFS#1635 tuples.hh: use variadic templates for in- and output operators
# Metadata
| Property | Value |
| -------- | ----- |
| Reported by | Ansgar Burchardt (burchardt@igpm.rwth-aachen.de) |
| Reported at | May 5, 2015 11:47 |
| Type | Bug Report |
| Version | Git (pre2.4) [cmake] |
| Operating Sys...
# Metadata
| Property | Value |
| -------- | ----- |
| Reported by | Ansgar Burchardt (burchardt@igpm.rwth-aachen.de) |
| Reported at | May 5, 2015 11:47 |
| Type | Bug Report |
| Version | Git (pre2.4) [cmake] |
| Operating System | Unspecified / All |
| Last edited by | Christoph Grüninger (gruenich@iws.uni-stuttgart.de) |
| Last edited at | May 6, 2015 12:09 |
| Closed by | Christoph Grüninger (gruenich@iws.uni-stuttgart.de) |
| Closed at | May 6, 2015 12:09 |
| Closed in version | Unknown |
| Resolution | Fixed |
| Comment | |
# Description
Hi,
by chance I noticed that tuples.hh doesn't yet use variadic templates for the in- and output operators for tuples, but if I remember correctly the use of these is allowed by now in dune.
I've attached a patch to switch the implementation to use variadic templates instead and also included a test for both oeprators.
Ansgar
# Attachments
* [0001-Use-variadic-templates-for-tuple-in-and-output-opera.patch](/uploads/8c1c04cd143d1fe6b111fe5d35f8fabd/0001-Use-variadic-templates-for-tuple-in-and-output-opera.patch)
* [0002-Add-test-for-tuple-in-and-output.patch](/uploads/b9dd0993da67d156028f89bca79709d6/0002-Add-test-for-tuple-in-and-output.patch)
* [0003-Normalize-executable-name-for-tuplestest.patch](/uploads/eb2753b4d360ccf8851bfaf02878f93d/0003-Normalize-executable-name-for-tuplestest.patch)
https://gitlab.dune-project.org/flyspray/FS/-/issues/1634FS#1634 testdebugallocator_fail1 does not build with gcc-4.92015-11-03T07:13:53ZCarsten Gräsergraeser@math.fau.deFS#1634 testdebugallocator_fail1 does not build with gcc-4.9
# Metadata
| Property | Value |
| -------- | ----- |
| Reported by | Carsten Gräser (graeser@math.fu-berlin.de) |
| Reported at | May 5, 2015 09:17 |
| Type | Bug Report |
| Version | Git (pre2.4) [cmake] |
| Operating System | ...
# Metadata
| Property | Value |
| -------- | ----- |
| Reported by | Carsten Gräser (graeser@math.fu-berlin.de) |
| Reported at | May 5, 2015 09:17 |
| Type | Bug Report |
| Version | Git (pre2.4) [cmake] |
| Operating System | Linux 64bit |
| Last edited by | Carsten Gräser (graeser@math.fu-berlin.de) |
| Last edited at | May 5, 2015 10:34 |
# Description
The failure happens on a 64bit ubuntu-15.04 with packaged gcc-4.9 and a debug build. The reported error is on the exception specifier:
In file included from /home/graeser/dune_testing/dune-common/dune/common/test/testdebugallocator.cc:10:0:
/home/graeser/dune_testing/dune-common/dune/common/debugallocator.hh: In function ‘void* operator new(size_t)’:
/home/graeser/dune_testing/dune-common/dune/common/debugallocator.hh:297:54: error: declaration of ‘void* operator new(size_t) throw (std::bad_alloc)’ has a different exception specifier
void * operator new(size_t size) throw(std::bad_alloc)
^
In file included from /usr/include/c++/4.9/ext/new_allocator.h:33:0,
from /usr/include/x86_64-linux-gnu/c++/4.9/bits/c++allocator.h:33,
from /usr/include/c++/4.9/bits/allocator.h:46,
from /usr/include/c++/4.9/vector:61,
from /home/graeser/dune_testing/dune-common/dune/common/debugallocator.hh:9,
from /home/graeser/dune_testing/dune-common/dune/common/test/testdebugallocator.cc:10:
/usr/include/c++/4.9/new:128:7: error: from previous declaration ‘void* operator new(std::size_t)’
void* operator new(std::size_t) _GLIBCXX_THROW (std::bad_alloc)
^
https://gitlab.dune-project.org/flyspray/FS/-/issues/1633FS#1633 Use lambdas instead of AnalyticGridFunction2015-05-08T12:45:09ZChristoph GrüningerFS#1633 Use lambdas instead of AnalyticGridFunction
# Metadata
| Property | Value |
| -------- | ----- |
| Reported by | Christoph Grüninger (gruenich@iws.uni-stuttgart.de) |
| Reported at | Apr 30, 2015 14:32 |
| Type | Feature Request |
| Version | 2.3 |
| Operating System | Un...
# Metadata
| Property | Value |
| -------- | ----- |
| Reported by | Christoph Grüninger (gruenich@iws.uni-stuttgart.de) |
| Reported at | Apr 30, 2015 14:32 |
| Type | Feature Request |
| Version | 2.3 |
| Operating System | Unspecified / All |
| Last edited by | Christoph Grüninger (gruenich@iws.uni-stuttgart.de) |
| Last edited at | May 8, 2015 12:45 |
| Closed by | Christoph Grüninger (gruenich@iws.uni-stuttgart.de) |
| Closed at | May 8, 2015 12:45 |
| Closed in version | Unknown |
| Resolution | Not a bug |
| Comment | |
# Description
Is there a reason to stick to AnalyticGridFunction to define boundary conditions and properties like permeability/condactivity/persistens/whatever? Wouldn't it be possible to use lambda functions instead? This would reduce the complex and template-prone AnalyticGridFunction stuff and reduce the number of template parameters for several local operators.
With GCC 4.7 as the minimal required compiler this should be usable, shouldn't it?
https://gitlab.dune-project.org/flyspray/FS/-/issues/1632FS#1632 commit 13481f3bb3 (Pk2DLocalBasis) breaks virtualshapefunctiontest2015-04-29T15:56:29ZMarkus BlattFS#1632 commit 13481f3bb3 (Pk2DLocalBasis) breaks virtualshapefunctiontest
# Metadata
| Property | Value |
| -------- | ----- |
| Reported by | Markus Blatt (markus@dr-blatt.de) |
| Reported at | Apr 29, 2015 15:47 |
| Type | Bug Report |
| Version | Git (pre2.4) [cmake] |
| Operating System | Unspecif...
# Metadata
| Property | Value |
| -------- | ----- |
| Reported by | Markus Blatt (markus@dr-blatt.de) |
| Reported at | Apr 29, 2015 15:47 |
| Type | Bug Report |
| Version | Git (pre2.4) [cmake] |
| Operating System | Unspecified / All |
| Last edited by | Oliver Sander (oliver.sander@tu-dresden.de) |
| Last edited at | Apr 29, 2015 15:56 |
| Closed by | Oliver Sander (oliver.sander@tu-dresden.de) |
| Closed at | Apr 29, 2015 15:56 |
| Closed in version | 2.4 |
| Resolution | Fixed |
| Comment | 330e79aa2cffbae2a3cbf2d99f34b8d9415bb919 |
# Description
g++ -std=c++0x -DHAVE_CONFIG_H -I. -I../../.. -pthread -I/home/mblatt/buildbot-slave1/DUNE-1/git/master/dune-common -I/home/mblatt/buildbot-slave1/DUNE-1/git/master/dune-common -I/home/mblatt/buildbot-slave1/DUNE-1/git/master/dune-geometry -I/home/mblatt/buildbot-slave1/DUNE-1/git/master/dune-geometry -I../../.. -g -O2 -MT virtualshapefunctiontest-virtualshapefunctiontest.o -MD -MP -MF .deps/virtualshapefunctiontest-virtualshapefunctiontest.Tpo -c -o virtualshapefunctiontest-virtualshapefunctiontest.o `test -f 'virtualshapefunctiontest.cc' || echo './'`virtualshapefunctiontest.cc
In file included from ../../../dune/localfunctions/lagrange/pk2d.hh:12,
from ../../../dune/localfunctions/lagrange/pq22d.hh:11,
from virtualshapefunctiontest.cc:16:
../../../dune/localfunctions/lagrange/pk2d/pk2dlocalbasis.hh: In member function ‘void Dune::Pk2DLocalBasis<D, R, k>::evaluate(const std::array<int, k>&, const typename Dune::LocalBasisTraits<D, 2, Dune::FieldVector<K, 2>, R, 1, Dune::FieldVector<R, 1>, Dune::FieldMatrix<R, 1, 2>, 2>::DomainType&, std::vector<typename Dune::LocalBasisTraits<D, 2, Dune::FieldVector<K, 2>, R, 1, Dune::FieldVector<R, 1>, Dune::FieldMatrix<R, 1, 2>, 2>::RangeType, std::allocator<typename Dune::LocalBasisTraits<D, 2, Dune::FieldVector<K, 2>, R, 1, Dune::FieldVector<R, 1>, Dune::FieldMatrix<R, 1, 2>, 2>::RangeType> >&) const [with unsigned int order = 1u, D = double, R = double, unsigned int k = 2u]’:
../../../dune/localfunctions/common/virtualwrappers.hh:111: instantiated from ‘void Dune::LocalBasisVirtualImp<T, Imp>::evaluate(const std::array<int, T::diffOrder>&, const typename T::DomainType&, std::vector<typename T::RangeType, std::allocator<typename T::RangeType> >&) const [with T = Dune::LocalBasisTraits<double, 2, Dune::FieldVector<double, 2>, double, 1, Dune::FieldVector<double, 1>, Dune::FieldMatrix<double, 1, 2>, 1>, Imp = Dune::Pk2DLocalBasis<double, double, 2u>]’
virtualshapefunctiontest.cc:197: instantiated from here
../../../dune/localfunctions/lagrange/pk2d/pk2dlocalbasis.hh:169: error: no match for ‘operator>’ in ‘((const Dune::Pk2DLocalBasis<double, double, 2u>*)this)->Dune::Pk2DLocalBasis<D, R, k>::order [with D = double, R = double, unsigned int k = 2u] > Dune::LocalBasisTraits<double, 2, Dune::FieldVector<double, 2>, double, 1, Dune::FieldVector<double, 1>, Dune::FieldMatrix<double, 1, 2>, 2>::diffOrder’
../../../dune/localfunctions/common/virtualwrappers.hh:111: instantiated from ‘void Dune::LocalBasisVirtualImp<T, Imp>::evaluate(const std::array<int, T::diffOrder>&, const typename T::DomainType&, std::vector<typename T::RangeType, std::allocator<typename T::RangeType> >&) const [with T = Dune::LocalBasisTraits<double, 2, Dune::FieldVector<double, 2>, double, 1, Dune::FieldVector<double, 1>, Dune::FieldMatrix<double, 1, 2>, 1>, Imp = Dune::Pk2DLocalBasis<double, double, 2u>]’
virtualshapefunctiontest.cc:197: instantiated from here
../../../dune/localfunctions/lagrange/pk2d/pk2dlocalbasis.hh:172: error: invalid use of member (did you forget the ‘&’ ?)
../../../dune/localfunctions/lagrange/pk2d/pk2dlocalbasis.hh:174: error: invalid use of member (did you forget the ‘&’ ?)
../../../dune/localfunctions/common/virtualwrappers.hh:111: instantiated from ‘void Dune::LocalBasisVirtualImp<T, Imp>::evaluate(const std::array<int, T::diffOrder>&, const typename T::DomainType&, std::vector<typename T::RangeType, std::allocator<typename T::RangeType> >&) const [with T = Dune::LocalBasisTraits<double, 2, Dune::FieldVector<double, 2>, double, 1, Dune::FieldVector<double, 1>, Dune::FieldMatrix<double, 1, 2>, 1>, Imp = Dune::Pk2DLocalBasis<double, double, 2u>]’
virtualshapefunctiontest.cc:197: instantiated from here
../../../dune/localfunctions/lagrange/pk2d/pk2dlocalbasis.hh:176: error: invalid use of member (did you forget the ‘&’ ?)
../../../dune/localfunctions/lagrange/pk2d/pk2dlocalbasis.hh: In member function ‘void Dune::Pk2DLocalBasis<D, R, k>::evaluate(const std::array<int, k>&, const typename Dune::LocalBasisTraits<D, 2, Dune::FieldVector<K, 2>, R, 1, Dune::FieldVector<R, 1>, Dune::FieldMatrix<R, 1, 2>, 2>::DomainType&, std::vector<typename Dune::LocalBasisTraits<D, 2, Dune::FieldVector<K, 2>, R, 1, Dune::FieldVector<R, 1>, Dune::FieldMatrix<R, 1, 2>, 2>::RangeType, std::allocator<typename Dune::LocalBasisTraits<D, 2, Dune::FieldVector<K, 2>, R, 1, Dune::FieldVector<R, 1>, Dune::FieldMatrix<R, 1, 2>, 2>::RangeType> >&) const [with unsigned int order = 2u, D = double, R = double, unsigned int k = 2u]’:
../../../dune/localfunctions/common/virtualwrappers.hh:111: instantiated from ‘void Dune::LocalBasisVirtualImp<T, Imp>::evaluate(const std::array<int, T::diffOrder>&, const typename T::DomainType&, std::vector<typename T::RangeType, std::allocator<typename T::RangeType> >&) const [with T = Dune::LocalBasisTraits<double, 2, Dune::FieldVector<double, 2>, double, 1, Dune::FieldVector<double, 1>, Dune::FieldMatrix<double, 1, 2>, 2>, Imp = Dune::Pk2DLocalBasis<double, double, 2u>]’
virtualshapefunctiontest.cc:197: instantiated from here
../../../dune/localfunctions/lagrange/pk2d/pk2dlocalbasis.hh:169: error: no match for ‘operator>’ in ‘((const Dune::Pk2DLocalBasis<double, double, 2u>*)this)->Dune::Pk2DLocalBasis<D, R, k>::order [with D = double, R = double, unsigned int k = 2u] > Dune::LocalBasisTraits<double, 2, Dune::FieldVector<double, 2>, double, 1, Dune::FieldVector<double, 1>, Dune::FieldMatrix<double, 1, 2>, 2>::diffOrder’
../../../dune/localfunctions/common/virtualwrappers.hh:111: instantiated from ‘void Dune::LocalBasisVirtualImp<T, Imp>::evaluate(const std::array<int, T::diffOrder>&, const typename T::DomainType&, std::vector<typename T::RangeType, std::allocator<typename T::RangeType> >&) const [with T = Dune::LocalBasisTraits<double, 2, Dune::FieldVector<double, 2>, double, 1, Dune::FieldVector<double, 1>, Dune::FieldMatrix<double, 1, 2>, 2>, Imp = Dune::Pk2DLocalBasis<double, double, 2u>]’
virtualshapefunctiontest.cc:197: instantiated from here
../../../dune/localfunctions/lagrange/pk2d/pk2dlocalbasis.hh:172: error: invalid use of member (did you forget the ‘&’ ?)
../../../dune/localfunctions/lagrange/pk2d/pk2dlocalbasis.hh:174: error: invalid use of member (did you forget the ‘&’ ?)
../../../dune/localfunctions/common/virtualwrappers.hh:111: instantiated from ‘void Dune::LocalBasisVirtualImp<T, Imp>::evaluate(const std::array<int, T::diffOrder>&, const typename T::DomainType&, std::vector<typename T::RangeType, std::allocator<typename T::RangeType> >&) const [with T = Dune::LocalBasisTraits<double, 2, Dune::FieldVector<double, 2>, double, 1, Dune::FieldVector<double, 1>, Dune::FieldMatrix<double, 1, 2>, 2>, Imp = Dune::Pk2DLocalBasis<double, double, 2u>]’
virtualshapefunctiontest.cc:197: instantiated from here
../../../dune/localfunctions/lagrange/pk2d/pk2dlocalbasis.hh:176: error: invalid use of member (did you forget the ‘&’ ?)
make[4]: *** [virtualshapefunctiontest-virtualshapefunctiontest.o] Fehler 1
make[4]: Leaving directory `/home/mblatt/buildbot-slave1/DUNE-1/git/master/dune-localfunctions/dune/localfunctions/test'
https://gitlab.dune-project.org/flyspray/FS/-/issues/1631FS#1631 Fix documentation of integrationOuterNormal2015-04-29T12:57:02ZFelix GruberFS#1631 Fix documentation of integrationOuterNormal
# Metadata
| Property | Value |
| -------- | ----- |
| Reported by | Felix Gruber (gruber@igpm.rwth-aachen.de) |
| Reported at | Apr 28, 2015 13:42 |
| Type | Bug Report |
| Version | Git (pre2.4) [cmake] |
| Operating System | ...
# Metadata
| Property | Value |
| -------- | ----- |
| Reported by | Felix Gruber (gruber@igpm.rwth-aachen.de) |
| Reported at | Apr 28, 2015 13:42 |
| Type | Bug Report |
| Version | Git (pre2.4) [cmake] |
| Operating System | Unspecified / All |
| Last edited by | Oliver Sander (oliver.sander@tu-dresden.de) |
| Last edited at | Apr 29, 2015 12:57 |
| Closed by | Oliver Sander (oliver.sander@tu-dresden.de) |
| Closed at | Apr 29, 2015 12:57 |
| Closed in version | Unknown |
| Resolution | Fixed |
| Comment | commit d3c1350b4d5ade05f5f3cd4c8372612922051e4f
thanks |
# Description
integrationOuterNormal returns a scaled *unit* outer normal, but the documentation suggested that it was not a (scaled) unit vector.
The attached patch clarifies the documentation.
# Attachments
* [Fix-documentation-of-integrationOuterNorm.patch](/uploads/f1e06bb295fb343c4df5918a5f4f0e13/Fix-documentation-of-integrationOuterNorm.patch)
https://gitlab.dune-project.org/flyspray/FS/-/issues/1630FS#1630 find used without directory argument in dunecontrol2015-04-27T07:31:39ZFlyspray ImporterFS#1630 find used without directory argument in dunecontrol
# Metadata
| Property | Value |
| -------- | ----- |
| Reported by | Claus-Justus Heine (claus-justus.heine@ians.uni-stuttgart.de) |
| Reported at | Apr 27, 2015 07:22 |
| Type | Bug Report |
| Version | 2.3 |
| Operating System...
# Metadata
| Property | Value |
| -------- | ----- |
| Reported by | Claus-Justus Heine (claus-justus.heine@ians.uni-stuttgart.de) |
| Reported at | Apr 27, 2015 07:22 |
| Type | Bug Report |
| Version | 2.3 |
| Operating System | Unspecified / All |
| Last edited by | Christoph Grüninger (gruenich@iws.uni-stuttgart.de) |
| Last edited at | Apr 27, 2015 07:31 |
| Closed by | Christoph Grüninger (gruenich@iws.uni-stuttgart.de) |
| Closed at | Apr 27, 2015 07:31 |
| Closed in version | Unknown |
| Resolution | Fixed |
| Comment | Thanks for the patch, applied. |
# Description
dune-common/bin/dunecontrol uses Unix find without directory argument in one place. Patch included. GNU find may allow to omit the directory argument, but in general the directory argument is mandatory. The bug was introduced by commit b54793c6e4de0bae301fc663537b9fb85ec1ca49.
# Attachments
* [2e2b6621785d292bdb2cc4f065be211514c21215](/uploads/a7ed3403d7a5a8f07fa1caf405b9e34b/2e2b6621785d292bdb2cc4f065be211514c21215)
https://gitlab.dune-project.org/flyspray/FS/-/issues/1629FS#1629 Bug in dune_target_link-libraries()2015-05-12T04:37:51ZFlyspray ImporterFS#1629 Bug in dune_target_link-libraries()
# Metadata
| Property | Value |
| -------- | ----- |
| Reported by | Stefan Girke (stefan.girke@gmx.de) |
| Reported at | Apr 27, 2015 05:35 |
| Type | Bug Report |
| Version | 2.3 |
| Operating System | Unspecified / All |
| La...
# Metadata
| Property | Value |
| -------- | ----- |
| Reported by | Stefan Girke (stefan.girke@gmx.de) |
| Reported at | Apr 27, 2015 05:35 |
| Type | Bug Report |
| Version | 2.3 |
| Operating System | Unspecified / All |
| Last edited by | Christoph Grüninger (gruenich@iws.uni-stuttgart.de) |
| Last edited at | May 12, 2015 04:37 |
| Closed by | Christoph Grüninger (gruenich@iws.uni-stuttgart.de) |
| Closed at | May 12, 2015 04:37 |
| Closed in version | Unknown |
| Resolution | Fixed |
| Comment | Thanks for the patch. Applied to master, 2.4 release and the 2.3 release branch. |
# Description
I guess, that there is a small (but tricky) bug in the dune_target_link-libraries()-method in DuneMacro.cmake.
The error arises when someone wants to add more than one library and wants to use this library in an further dune-module.
This happened with "zlib" in dune-alugrid in combination with dune-fem.
Find the fix patch attached.
# Attachments
* [0001-fix-dune_target_link_libraries.patch](/uploads/894301551769e56c21f37f9f107b25da/0001-fix-dune_target_link_libraries.patch)