Skip to content

#1013 Remove FiniteStack class

Metadata

Property Value
Reported by Oliver Sander (oliver.sander@tu-dresden.de)
Reported at Jan 6, 2012 15:20
Type Feature Request
Version Git (pre2.4) [autotools]
Operating System Unspecified / All
Last edited by Oliver Sander (oliver.sander@tu-dresden.de)
Last edited at Feb 6, 2012 15:04
Closed by Oliver Sander (oliver.sander@tu-dresden.de)
Closed at Feb 6, 2012 15:04
Closed in version Unknown
Resolution Not a bug
Comment The issue raised by Robert is of course important, but should be dealt with in a separate FlySpray thread.

Description

The FiniteStack class is basically a typedef for std::stackDune::ReservedVector. All it does additionally is to implement a method 'full', and reimplement 'pop' in a non-stl-conforming way.

Can we replace the reimplementation of 'pop' to have stl compliance?

Since that reimplementation is pretty much the entire code of the class, can we get rid of the class altogether, and have people use std::stackDune::ReservedVector directly?