#1242 Possible bug in Dune-ISTL's configure-time detection of SuperLU
Metadata
Property | Value |
---|---|
Reported by | Bård Skaflestad (bard.skaflestad@sintef.no) |
Reported at | Jan 30, 2013 19:23 |
Type | Discussion |
Version | 2.2 |
Operating System | Unspecified / All |
Last edited by | Christoph Grüninger (gruenich@iws.uni-stuttgart.de) |
Last edited at | Jan 31, 2013 03:56 |
Closed by | Christoph Grüninger (gruenich@iws.uni-stuttgart.de) |
Closed at | Jan 31, 2013 03:56 |
Closed in version | Unknown |
Resolution | Fixed |
Comment | Fixed in r1778, thanks for the patch. |
Description
All,
In tracking down a build issue in an unrelated, external module, I happened upon a latent issue in the DUNE_PATH_SUPERLU and DUNE_PATH_SUPERLU_DIST macros (dune-istl/m4/superlu.m4 and dune-istl/m4/superlu-dist.m4). Unless I am mistaken, these macros do not properly guard against possibility of someone specifying
--with-superlu=yes
at configure time.
Granted, the documentation for '--with-superlu' does state that the parameter be a (valid) path rather than some arbitrary string but as introducing the guard is simple (attached), may I suggest that a latent issue be avoided? In particular, the "eval cd" trick fails if "$withval" is invalid.