#1654 Some important improvements for dune_enable_all_packages()
Metadata
Property | Value |
---|---|
Reported by | Steffen Müthing (steffen.muething@iwr.uni-heidelberg.de) |
Reported at | May 19, 2015 08:01 |
Type | Feature Request |
Version | Git (pre2.4) [cmake] |
Operating System | Unspecified / All |
Last edited by | Steffen Müthing (steffen.muething@iwr.uni-heidelberg.de) |
Last edited at | May 19, 2015 13:23 |
Closed by | Steffen Müthing (steffen.muething@iwr.uni-heidelberg.de) |
Closed at | May 19, 2015 13:23 |
Closed in version | 2.4 |
Resolution | Fixed |
Comment | Merged feature/FS1654-improve-dune-enable-all-packages to master and backported: |
7cc5bc4 master 2159a9d releases/2.4
Sorry for moving so quickly, but I really need this fix to be able to continue working... |
Description
When converting PDELab to use dune_enable_all_packages(), I stumbled over a problem that would really benefit from having a CMake function dune_target_enable_all_packages() (see http://conan2.iwr.uni-heidelberg.de/git/pdelab/dune-pdelab/issues/14). So I added that function and also did some additional cleanup work in the CMake module:
- Better documentation
- Fixed some bugs
- Added the possibility to handle compile options separately from compile definitions (which CMake really prefers you to do).
I've pushed the changes to feature/FS1654-improve-dune-enable-all-packages in dune-common. If there aren't any urgent objections, I'll merge this pretty quickly because having PDELab not compile on my machine right now is rather annoying... ;-)
These changes should also be backported to the release, I've tagged them accordingly.