#1660 (un)signedness of indices or dimensions
Metadata
Property | Value |
---|---|
Reported by | Martin Nolte (nolte@mathematik.uni-freiburg.de) |
Reported at | Jun 4, 2015 12:41 |
Type | Bug Report |
Version | Git (pre2.4) [cmake] |
Operating System | Unspecified / All |
Description
Currently the signedness ofdimensions or indices in the DUNE core is arbitrary. Sometimes a codimension is an int
(e.g., in the Codim
structures), sometimes it is an unsigned int
(e.g., in the indexSet.subIndex
). Similarly, subentity indices are sometimes int
(e.g., refElement.subEntity
returns an int
), sometimes they are unsigned
(e.g., LocalKey.subEntity
).
The different signedness frequently triggers gcc warnings. These in turn need to be circumvented by an explicit static_cast
, unnecessarily cluttering the code.
I think it is time for a final decision on this signedness issue. I'm fine with either of them, but the mixture is a mess.