Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
  • Sign in
FS
FS
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 125
    • Issues 125
    • List
    • Board
    • Labels
    • Milestones
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Commits
  • Issue Boards
  • flyspray
  • FSFS
  • Issues
  • #1660

Closed
Open
Opened Jun 04, 2015 by Martin Nolte@martin.nolte
  • Report abuse
  • New issue
Report abuse New issue

#1660 (un)signedness of indices or dimensions

Metadata

Property Value
Reported by Martin Nolte (nolte@mathematik.uni-freiburg.de)
Reported at Jun 4, 2015 12:41
Type Bug Report
Version Git (pre2.4) [cmake]
Operating System Unspecified / All

Description

Currently the signedness ofdimensions or indices in the DUNE core is arbitrary. Sometimes a codimension is an int (e.g., in the Codim structures), sometimes it is an unsigned int (e.g., in the indexSet.subIndex). Similarly, subentity indices are sometimes int (e.g., refElement.subEntity returns an int), sometimes they are unsigned (e.g., LocalKey.subEntity).

The different signedness frequently triggers gcc warnings. These in turn need to be circumvented by an explicit static_cast, unnecessarily cluttering the code.

I think it is time for a final decision on this signedness issue. I'm fine with either of them, but the mixture is a mess.

Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
No due date
3
Labels
bug discussion task
Assign labels
  • View project labels
Reference: flyspray/FS#1660