#302 wrong usage of config.h
Metadata
| Property | Value |
|---|---|
| Reported by | Christian Engwer (christi@conan.iwr.uni-heidelberg.de) |
| Reported at | Jul 17, 2007 13:27 |
| Type | Bug Report |
| Version | Git (pre2.4) [autotools] |
| Operating System | Unspecified / All |
| Closed by | Oliver Sander (oliver.sander@tu-dresden.de) |
| Closed at | Jul 24, 2007 13:03 |
| Closed in version | 1.0 |
| Resolution | Fixed |
| Comment | Fixed in dune-disc revision 438. |
Description
-
header must not include config.h, this includes cc-files, if they are included by header files.
-
cc-files should include config.h, if they are compiled into object files.
-
config.h should be incuded via #include <config.h>
I think these bugs are easy to fix and are quite severe bugs, therefor I marked this bug "1.0". These bugs will render Dune without config.h unusable.
dune-grid/trunk and dune-disc/releases/1.0: ./grid/io/file/amiramesh/amuggridreader.cc:#include <dune/config.h>
dune-disc/trunk and dune-disc/releases/1.0: ./disc/stokes/dgstokes.cc:# include "config.h" // autoconf defines, needed by the dune headers ./disc/stokes/testfunctions.cc:# include "config.h" // autoconf defines, needed by the dune headers ./disc/stokes/rhs.cc:# include "config.h" // autoconf defines, needed by the dune headers ./disc/stokes/boundaryconditions.cc:# include "config.h" // autoconf defines, needed by the dune headers ./disc/shapefunctions/lagrangeshapefunctions.cc:#include "config.h"