#455 tuples.hh uses preprocessor symbols to rename classes
Metadata
| Property | Value |
|---|---|
| Reported by | Martin Nolte (nolte@mathematik.uni-freiburg.de) |
| Reported at | Nov 10, 2008 09:56 |
| Type | Bug Report |
| Version | Git (pre2.4) [autotools] |
| Operating System | Unspecified / All |
| Last edited by | Oliver Sander (oliver.sander@tu-dresden.de) |
| Last edited at | Feb 18, 2009 10:20 |
| Closed by | Oliver Sander (oliver.sander@tu-dresden.de) |
| Closed at | Feb 18, 2009 10:20 |
| Closed in version | 1.2 |
| Resolution | Fixed |
| Comment | Only a single define remained. Fixed it on the trunk in revision 5441. Will not be fixed in 1.2. |
Description
In dune-common/common/tuples.hh preprocessor defines are used to rename new tr1 implementations into the old Dune names:
#define ElementType tuple_element #define Size tuple_size #define Tuple tuple
As these names are used locally in other code fragments, too. Bugs resulting from this defines are very hard to track.
Please think twice before using the preprocessor. It causes trouble to others!
I already fixed ElementType, which was the cause of my trouble (Yes, I should simply have reverted the change)