#771 configure generated gridtype.hh / dgfgridtype.hh
Metadata
| Property | Value |
|---|---|
| Reported by | Martin Nolte (nolte@mathematik.uni-freiburg.de) |
| Reported at | Apr 12, 2010 11:23 |
| Type | Feature Request |
| Version | Git (pre2.4) [autotools] |
| Operating System | Unspecified / All |
| Last edited by | Andreas Dedner (A.S.Dedner@warwick.ac.uk) |
| Last edited at | Aug 9, 2010 11:07 |
| Closed by | Andreas Dedner (A.S.Dedner@warwick.ac.uk) |
| Closed at | Aug 9, 2010 11:07 |
| Closed in version | 2.1 |
| Resolution | Implemented |
| Comment | gridtype definitions have been |
| added to config.h with | |
| meaningful introductory comment |
Description
From the mailing-list it seems there is the need for some discussion of patch 6391 (and some followups):
"Allow header files for grid selection to be generated by configure script
The preprocessor magic for selecting the grid currently cannot be extended to support grids from modules other that dune-grid. Moreover, the code is mostly 'cut & paste', which is a problem for maintenance.
This patch overcomes both difficulties. The files 'gridtype.hh' and 'dgfgridtype.hh' are generated for each module by configure. They contain the switches for all the grids found. To add an additional grid, just add a call to DUNE_DEFINE_GRIDTYPE in the main m4-file of the module that contains it (see e.g. dune-grid/m4/dune_grid.m4 or dune-grid/m4/alberta.m4) All the preprocessor stuff is then generated from this line."
So, I think a FlySpray task will be the right place to discuss this patch. It might also be instructive to know everybody's attitude towards the "preprocessor magic".