Skip to content

#861 duneproject: Generates invalid Makefile.am if project name has more than two dashes

Metadata

Property Value
Reported by Ansgar Burchardt (burchardt@igpm.rwth-aachen.de)
Reported at Jan 4, 2011 18:46
Type Bug Report
Version Git (pre2.4) [autotools]
Operating System Unspecified / All
Last edited by Christian Engwer (christi@conan.iwr.uni-heidelberg.de)
Last edited at Jan 4, 2011 18:56
Closed by Christian Engwer (christi@conan.iwr.uni-heidelberg.de)
Closed at Jan 4, 2011 18:56
Closed in version Unknown
Resolution Fixed
Comment in dune-common revision 6304

Description

duneproject generates a Makefile.am if the project name has more than two dashes in it.

Example session: % ./dune-common/bin/duneproject [...]

  1. Name of your new Project? (e.g.: dune-grid): dune-a-b-c
  2. Which modules should this module depend on? Following modules are found: dune-common dune-pdelab dune-grid dune-istl dune-localfunctions dune-grid-dev-howto dune-grid-howto dune-pdelab-howto Enter space separated list: dune-common
  3. Project/Module version? 0.1
  4. Maintainers email address? me@example.com

creating Project "dune-a-b-c", version 0.1 [...] writing initial files:

  • dune-a-b-c/configure.ac [... These are the problematic files: ]
  • dune-a-b-c/dune/a_b-c
  • dune-a-b-c/dune/Makefile.am
  • dune-a-b-c/dune/a_b-c/Makefile.am
  • dune-a-b-c/dune/a_b-c/a_b-c.hh [...]

Running dunecontrol --only=dune-a-b-c all' gives this error: dune/a_b-c/Makefile.am:1: bad characters in variable name a_b-cincludedir' dune/a_b-c/Makefile.am:2: bad characters in variable name `a_b-cinclude_HEADERS'

The bug is present in both 2.0 and the current SVN trunk (r6303).

A simple solution would be to just convert all minuses "-" to an underscore "_".

Regards, Ansgar