#955 typedef Jacobian in the Geometry class.
Metadata
| Property | Value |
|---|---|
| Reported by | Robert K (robertk@posteo.org) |
| Reported at | Sep 26, 2011 14:11 |
| Type | Feature Request |
| Version | Git (pre2.4) [autotools] |
| Operating System | Unspecified / All |
| Last edited by | Oliver Sander (oliver.sander@tu-dresden.de) |
| Last edited at | Jul 18, 2015 17:42 |
| Closed by | Oliver Sander (oliver.sander@tu-dresden.de) |
| Closed at | Jul 18, 2015 17:42 |
| Closed in version | 3.0 |
| Resolution | Implemented |
| Comment | The original request has been implemented a long time ago. Please open a new bug if there should be new issues. |
Description
I suggest to change the following two lines in the Geometry interface implementation:
--- geometry.hh (revision 7670) +++ geometry.hh (working copy) @@ -91,12 +91,12 @@ typedef FieldVector< ctype, cdim > GlobalCoordinate;
//! type of jacobian (also of jacobian inverse transposed)
- typedef FieldMatrix<ctype,cdim,mydim> Jacobian;
- //typedef typename ImplementationType :: Jacobian Jacobian;
-
//typedef FieldMatrix<ctype,cdim,mydim> Jacobian;
-
typedef typename ImplementationType :: Jacobian Jacobian;
//! type of jacobian transposed
- typedef FieldMatrix< ctype, mydim, cdim > JacobianTransposed;
- //typedef typename ImplementationType :: JacobianTransposed JacobianTransposed;
- //typedef FieldMatrix< ctype, mydim, cdim > JacobianTransposed;
- typedef typename ImplementationType :: JacobianTransposed JacobianTransposed;
This means that the implementation of the Jacobian/ JacobianTransposed is obtained from the implementation of the geometry. An already existing typedef in the GeometryDefaultImplementation still uses the FieldMatrix as before. This is a slight change that will simplify the future changes of the geometry interface. Geometry implementations that are not derived from GeometryDefaultImplementation would have to copy the two lines with the typedefs using FiledMatrix to the implementation.