Skip to content

#966 Remove unwanted semicolon at namespace-closing brace

Metadata

Property Value
Reported by Bård Skaflestad (bard.skaflestad@sintef.no)
Reported at Oct 26, 2011 18:10
Type Feature Request
Version 2.0
Operating System Unspecified / All
Last edited by Jö Fahlke (jorrit@jorrit.de)
Last edited at Oct 26, 2011 20:47
Closed by Jö Fahlke (jorrit@jorrit.de)
Closed at Oct 26, 2011 20:47
Closed in version Unknown
Resolution Fixed
Comment

Description

The Dune 'common' module has two instances of attaching a semicolon to the (Dune) "namespace"-closing brace (i.e., the '}' at the end of a "namespace" definition. This practice produces diagnostic messages from GCC (4.4) when run with the flags "-Wall -Wextra -pedantic".

Would you mind applying the "dune-common.diff" patch that I've attached to this issue?

Note, the "pdelab" module also does this in a number of places. I have attached a similar patch for that module, but as it is not a core module I'm at a loss as to whom to send it.

Sincerely,

Bård Skaflestad

Attachments