Core Modules issueshttps://gitlab.dune-project.org/groups/core/-/issues2017-04-07T14:32:03Zhttps://gitlab.dune-project.org/core/dune-grid/-/issues/35headercheck does not compile anymore.2017-04-07T14:32:03ZRobert Kheadercheck does not compile anymore.There have been some recent changes in dune/grid/test and dune/grid/identitygrid that make the headercheck fail.
@linus.seelinger : Please fix the test/yasp things
@oliver.sander : Please fix the identitygrid things
or use cmake macro...There have been some recent changes in dune/grid/test and dune/grid/identitygrid that make the headercheck fail.
@linus.seelinger : Please fix the test/yasp things
@oliver.sander : Please fix the identitygrid things
or use cmake macro
exclude_from_headercheck( header-name )
to remove failing headers from the list of headers to be tested.DUNE 2.5.0https://gitlab.dune-project.org/core/dune-grid/-/issues/34cmake doesn't inform whether UG is seq. or parallel2017-04-07T14:32:03ZChristian Engwercmake doesn't inform whether UG is seq. or parallelIn former times configure told us, whether UG was compiled with or without MPI. cmake doesn't tell this anymore, which is a bit annoying.In former times configure told us, whether UG was compiled with or without MPI. cmake doesn't tell this anymore, which is a bit annoying.DUNE 2.5.0https://gitlab.dune-project.org/core/dune-grid/-/issues/30test-ug does not build with clang, due to Hybrid::ifElse weirdness2017-04-07T14:32:04ZOliver Sanderoliver.sander@tu-dresden.detest-ug does not build with clang, due to Hybrid::ifElse weirdnesstest-ug builds fine with gcc. However, if fails to build with both clang-3.6 and clang-3.8.
Here's how far I got: in uggridindexsets.hh:75 there is a code block
Hybrid::ifElse(Std::bool_constant<cc==0>(), [&](auto id)
...test-ug builds fine with gcc. However, if fails to build with both clang-3.6 and clang-3.8.
Here's how far I got: in uggridindexsets.hh:75 there is a code block
Hybrid::ifElse(Std::bool_constant<cc==0>(), [&](auto id)
{
[...]
result = UG_NS<dim>::levelIndex(UG_NS<dim>::GetEdge(UG_NS<dim>::Corner(grid_->getRealImplementation(e).getTarget(), // ***
UGGridRenumberer<dim>::verticesDUNEtoUG(a,e.type())),
UG_NS<dim>::Corner(grid_->getRealImplementation(e).getTarget(),
UGGridRenumberer<dim>::verticesDUNEtoUG(b,e.type()))));
}
});
The cc==0 condition is static, therefore this code should really only be instantiated when cc==0. However, clang barfs at the line *** when the case cc==1 is tested. I attach the error message below.
@carsten.graeser , as you wrote the Hybrid::ifElse, could you please have a look? Thanks!
In file included from /home/sander/dune/dune-grid/dune/grid/test/test-ug.cc:14:
In file included from /home/sander/dune/dune-grid/dune/grid/uggrid.hh:125:
/home/sander/dune/dune-grid/dune/grid/uggrid/uggridindexsets.hh:86:84: error: cannot initialize a parameter of
type 'const UG_NS<2>::Element *' (aka 'const UG::D2::element *') with an rvalue of type 'typename
UG_NS<2>::Entity<codim>::T *' (aka 'UG::D2::edge *')
...grid_->getRealImplementation(e).getTarget(),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/sander/dune/dune-grid/dune/grid/common/indexidset.hh:178:31: note: in instantiation of function template
specialization 'Dune::UGGridLevelIndexSet<const Dune::UGGrid<2> >::subIndex<1>' requested here
return asImp().template subIndex< cc >( e, i, codim );
The error by itself is okay when cc==1, that is why a static if is used.DUNE 2.5.0https://gitlab.dune-project.org/core/dune-grid/-/issues/25UGGrid does not implement subIndex method for entities other than elements2018-01-15T15:13:10ZOliver Sanderoliver.sander@tu-dresden.deUGGrid does not implement subIndex method for entities other than elementsThis makes the tightened tests from !87 (and its improved version !89) fail.This makes the tightened tests from !87 (and its improved version !89) fail.DUNE 2.5.0Oliver Sanderoliver.sander@tu-dresden.deOliver Sanderoliver.sander@tu-dresden.dehttps://gitlab.dune-project.org/core/dune-common/-/issues/42DUNE 2.5 release2017-05-25T21:04:49ZAnsgar Burchardtansgar.burchardt@tu-dresden.deDUNE 2.5 releaseOliver and me propose to do a 2.5 release of DUNE before the end of the year to have a recent version of DUNE in the next Debian release.
Also for other users, we believe a new release makes it easier to support both the last stable rel...Oliver and me propose to do a 2.5 release of DUNE before the end of the year to have a recent version of DUNE in the next Debian release.
Also for other users, we believe a new release makes it easier to support both the last stable release and the current master of DUNE in external modules as the build system changed significantly since 2.4.
The release will be managed by @ansgar and @oliver.sander.
Our current rough plan is to create a release branch mid-October and plan for a first release candidate early November.
If required, this will be followed by a second release candidate mid-November.
The final release will then take place either mid-November or early-December (in case of two release candidates).
All issues and merge requests that should be included in DUNE 2.5 should be assigned to the "DUNE 2.5.0" milestone (once this is setup).
However, we will not delay the release if there are minor issues that are not dealt with in time.
We plan to also release the module in staging at the same time.DUNE 2.5.0https://gitlab.dune-project.org/core/dune-common/-/issues/37Drop support for clang-3.5?2017-08-04T09:59:29ZCarsten Gräsergraeser@math.fau.deDrop support for clang-3.5?Unfortunately I found out that clang-3.5 has a severe bug with the handling of `std::integer_sequence` which is maybe related to the `sizeof...` operator.
This does not only lead to compile failures. It's easy to give examples where c...Unfortunately I found out that clang-3.5 has a severe bug with the handling of `std::integer_sequence` which is maybe related to the `sizeof...` operator.
This does not only lead to compile failures. It's easy to give examples where clang-3.5 silently produces incorrect code. A dune-less test case using only `std::index_sequence` in an idiomatic non-artificial way for tuple-unpacking is attached to the corresponding issue in dune-functions: https://gitlab.dune-project.org/staging/dune-functions/issues/10
As a consequence we should either avoid using related features in dune or **drop
support for clang-3.5**. Since we are already using `std::integer_sequence`
in the core for some time I'd strongly vote for the latter
to avoid people running into hard to track issues with
correct code producing wrong results.DUNE 2.5.0https://gitlab.dune-project.org/core/dune-geometry/-/issues/4Remove genericgeometry subdirectory2017-05-21T00:35:09ZJö Fahlkejorrit@jorrit.deRemove genericgeometry subdirectoryThere are plans to remove the `genericgeometry` subdirectory, voiced [here](https://gitlab.dune-project.org/core/dune-common/issues/29#note_16281) in core/dune-common#29. This bug is for discussing them.There are plans to remove the `genericgeometry` subdirectory, voiced [here](https://gitlab.dune-project.org/core/dune-common/issues/29#note_16281) in core/dune-common#29. This bug is for discussing them.DUNE 2.5.0Martin NolteMartin Noltehttps://gitlab.dune-project.org/core/dune-common/-/issues/12"make test" fails when tests are skipped2017-06-05T05:56:11ZAnsgar Burchardtansgar.burchardt@tu-dresden.de"make test" fails when tests are skippedWith CMake skipped tests are treated as failures:
```
33/50 Test #33: parametertreelocaletest ..........***Skipped 0.00 sec
Start 34: parametertreetest
[...]
98% tests passed, 1 tests failed out of 50
[...]
The following...With CMake skipped tests are treated as failures:
```
33/50 Test #33: parametertreelocaletest ..........***Skipped 0.00 sec
Start 34: parametertreetest
[...]
98% tests passed, 1 tests failed out of 50
[...]
The following tests FAILED:
33 - parametertreelocaletest (Not Run)
```
There is a [bug report for CMake about this](http://public.kitware.com/Bug/view.php?id=15431), but it doesn't look like anything has been done so far.
It seems quite against the idea of marking tests as "skipped" to have "make test" fail.
In particular I want to build an automatically updated image of the 3.0-git DUNE core modules for an internal CI system, but would like to not use versions that do not pass the test suite.
That is, I would like to only use the updated image if "make test" succeeds, but don't care about skipped tests.
Would it be worth working around this CMake bug in `dune_add_test`?DUNE 2.5.0https://gitlab.dune-project.org/core/dune-grid/-/issues/8autotools fail to find dune-grid lib2017-04-07T14:32:14ZTobias Malkmusautotools fail to find dune-grid libA fix can be found in branch bugfix/libcheck-autotools
This should be added to the new release canidate 2.4r1.A fix can be found in branch bugfix/libcheck-autotools
This should be added to the new release canidate 2.4r1.DUNE 2.4.1Steffen Müthingsteffen.muething@iwr.uni-heidelberg.deSteffen Müthingsteffen.muething@iwr.uni-heidelberg.dehttps://gitlab.dune-project.org/core/dune-grid/-/issues/7Unit tests for the old alugrid fail to compile2017-04-07T14:32:14ZJö Fahlkejorrit@jorrit.deUnit tests for the old alugrid fail to compileWith g++-4.9.2, autotools buildsystem, alugrid-1.52 (tar ball), and today's releases/2.4 branches (core/dune-common@532a9f30, core/dune-geometry@1d263376, and 32b29ad3), ALUGrid-related unit tests fail to compile. The issues encountered...With g++-4.9.2, autotools buildsystem, alugrid-1.52 (tar ball), and today's releases/2.4 branches (core/dune-common@532a9f30, core/dune-geometry@1d263376, and 32b29ad3), ALUGrid-related unit tests fail to compile. The issues encountered seem to be mostly related to EntityPointer -> Entity conversions.
See also !30.DUNE 2.4.1https://gitlab.dune-project.org/core/dune-grid/-/issues/6dune-grid 2.4.1 Coordination Task2017-04-07T14:32:14ZSteffen Müthingsteffen.muething@iwr.uni-heidelberg.dedune-grid 2.4.1 Coordination TaskI'll use this task to track the backports for dune-common 2.4.1.
If you have suggestions for more fixes or concerns about one of the backports, please comment.
## Backported commits
- [x] e7d2296 [MCMGMapper] Fix misleading depr...I'll use this task to track the backports for dune-common 2.4.1.
If you have suggestions for more fixes or concerns about one of the backports, please comment.
## Backported commits
- [x] e7d2296 [MCMGMapper] Fix misleading deprecation message.
- [x] 34ce517 [PartitionSet] Make PartitionSet comparable
- [x] 652c97d [CMake] Include used CheckIncludeFiles
- [x] db4ad28 [CMake] Include used CheckIncludeFiles to FindGrape, too
- [x] 314870a Git ignore build-* instead of build-cmake.
- [x] 2a3d122 Make leafIndex for UG::Vector return the correct type (i.e., UG::UINT)
- [x] e5a1e28 Use UG::INT instead of int in order to conform with the interface
- [x] 2db4aa5 [albertagrid] don't ude deprecated EntityPointer (cherry picked from commit 1a64f01fe06c7888db258a4b68a61471122b4300)
- [x] e02e411 [albertagrid] add const qualifier, as we never change the geoInside object (cherry picked from commit 826825787f0406b2eef93476da48f2519cc1bc64)
- [x] 88284e1 Merge remote-tracking branch 'linus/master'
- [x] 665cc73 [Backport][Fixup] Add printgrid and associated test to autotools build system
- [x] df40525 [bugfix] add header guards and make headercheck pass
- [x] 5af719d do not require the node indices to be ordered
- [x] 0f13d14 Simplify default implementation of method hasBoundaryIntersections
- [x] b8bd3e0 add physical entities to gmsh output
- [x] 66f0861 Update list of copyright holders.
- [x] 27ef73c doc: Entity::father() no longer returns an EntityPointer
- [x] c7abb46 [gridcheck][bugfix] the size for codim > 0 failed when a grid did not have these entities.
- [x] 1cdf77e [bugfix] in a serial run we have one process, not zero.
- [x] 1b29152 Downgrade a static assertion to a regular assertion
- [x] 72e576f doc: refer to Grid::entity rather than the deprecated Grid::entityPointer
- [x] 0ac968c [bugfix] Throw an exception on all processes if the grid is too small
- [x] 5840007 [bugfix] Fix previous bugfix about too small overlapping grids
- [x] dd3858d [bugfix,yaspgrid] add HAVE_MPI marco to ensure mpi is present if MPI functions are used.
- [x] 2ae430d [bugfix] use ints for communicating around too small grids.
- [x] d8a6fbd Merge remote-tracking branch 'origin/feature/FS1690-parallel-tensorgrid-factory' (see flyspray/FS#1690)
- [x] 1be3f87 Don't use deprecated enums exported by the Geometry class
- [x] 4a4efee [bugfix,vtkwriter] make bind/unbind non-const
- [x] d430a25 [vtkwriter] extend vtkwriter to handle function which allow to call localFunction(f)
- [x] 3d97450 use coorddimension instead of dimensionworld
- [x] 4622204 [printgrid] Rename method to printGrid() to follow camelCase convention
- [x] 0a35667 [printgrid] Some minor fixes
- [x] 8d080ab [autotools] Make configure check pass on GCC 4.4
- [x] c9d52a2 Use MultiLinearGeometry to implement UGGrid local geometries, rathern than CachedMultiLinearGeometry
- [x] 7fe1229 Avoid two signed/unsigned warnings
- [x] a13a895 Add constructor for VTKSequenceWriter that takes a VTKWriter instead of a GridView
- [x] 8f13f03 Use the new constructor of VTKSequenceWriter
- [x] be4fe96 ensure number of boundary segments is correct before creating a possibly very large vector
- [x] 1c34e69 [bugfix] check that iterator is not end iterator before dereferencing !!!!
- [x] 4d92e02 [bugfix] Do not hard-wire the byte order, it is platform-dependend
- [x] a5cb8d2 [doc] due to a GCC bug we can not use "auto&&" for range based for
- [x] 557ddc9 Add new VTKSequenceWriter constructor that omits the 'path' and 'extendpath' arguments
- [x] 2b97fa9 [GlobalIndexSet] use unsigned int instead of uint
- [x] f937df8 [OneDGrid] Assert that vertices are specified when OneDGrid is initialized
- [x] 23be4e4 Add missing header to gmshtest
- [x] 397154f [bugfix] Use a gcc4.4 compliant header to test for dune-grid
- [x] 30998a7 [Bugfix] Pick yet another header for the dune-grid autotools check
- [x] 5405572 Merge branch 'master' into 'master'
- [x] ee496a9 avoid deprecated EntityPointer in DGFGridFactory for UGGrid
- [x] ec7c9f1 [UG][Cleanup] Use a value to capture a temporary Entity object
- [x] 522325f Merge branch 'Feature/issue2_missing_intersection_insertion_index_UG' into 'master' (see !20)
- [x] 20406ff Merge branch 'feature/make-intersectioniterator-a-forward-iterator' into 'master' (see !12)
- [x] 38fae0d Use Entities instead of the deprecated EntityPointer
- [x] e133d44 Merge branch 'skip-printgridtest-if-gnuplot-is-not-installed' into 'master' (see !25)
- [x] c35fa23 [ug] mark destructor of UGGrid as noexcept(false)
- [x] 8533125 Merge remote-tracking branch 'origin/feature/FS1713-add-config_h-bottom-section'
- [x] eb37886 Merge branch 'feature/fix-parmetisgridpartitioner-compilation' into 'master'
## Rejected/deferred merge requests and bugs
## Outstanding merge requests and bugs
- [x] c3c4944 [ALUGrid] Get rid of ALUSimplexGrid/ALUCubeGrid forward declarations. (see !30)
- [x] 3e170fb [alugrid.hh] No need to include the declarations twice. (see !30)
- [x] #7 Unit tests for the old alugrid fail to compile.
- [x] !34 Feature/fix parmetisgridpartitioner compilationDUNE 2.4.1Steffen Müthingsteffen.muething@iwr.uni-heidelberg.deSteffen Müthingsteffen.muething@iwr.uni-heidelberg.dehttps://gitlab.dune-project.org/core/dune-istl/-/issues/8dune-istl 2.4.1 Coordination Task2017-05-21T00:30:58ZSteffen Müthingsteffen.muething@iwr.uni-heidelberg.dedune-istl 2.4.1 Coordination TaskI'll use this task to track the backports for dune-common 2.4.1.
If you have suggestions for more fixes or concerns about one of the backports, please comment.
## Backported commits
- [x] f40f330 [bugfix][RestartedGMResSolver] s...I'll use this task to track the backports for dune-common 2.4.1.
If you have suggestions for more fixes or concerns about one of the backports, please comment.
## Backported commits
- [x] f40f330 [bugfix][RestartedGMResSolver] signature of method apply was wrong when real_type != double.
- [x] 8fe92a2 Git ignore build-* instead of build-cmake.
- [x] 61af51d [cleanup] Remove leftover (?) file Doxydep
- [x] b1882eb [galerkintest] Fix output of matrix size.
- [x] 9fe002f [bugfix] Use correct integral type in the graph classes.
- [x] cf48329 [release][repartition][bugfix] correct implementation of usage of ParMetis::idx_t for different versions of ParMetis.
- [x] d1da71f Make sure the vectors x and b handed to the 'apply' method have the correct size
- [x] 6de3455 [tests] Catch Dune exceptions to ease identifying problems.
- [x] e25671c [superlu] Ensure vectors x and b handed to 'apply' have same size
- [x] e95bfb9 [tests] Use correct sized rhs for Superlu/UMFPack sub-matrix tests
- [x] 6c9aa54 Merge branch 'feature/FS1659-Matlab-output-of-DynamicMatrix' into 'master'
- [x] 6c51c8f [bugfix] Choose a gcc4.4 compliant header to test for dune-istl
- [x] 8b2910b [test] Adjust exception handling in tests.
- [x] 26a591e Fix headercheck
- [x] e85759d Merge branch 'feature/smaller-cleanups' into 'master'
- [x] 2fdafaa Remove an out-commented test for a way to build a BCRSMatrix that won't work anyway
- [x] 922bd81 Merge branch 'feature/fix-shadow-warnings' into 'master'
- [x] 8d26a70 [CMake] Do not require BLAS
- [x] 9bf96e0 Merge branch 'feature/kamg-reference' into 'master'
- [x] a8f68be Provide operator[] for integral_constant<std::size_t, k> (needs some porting work)
- [x] 0196c61 Provide operator[] with integral_constant<std::size_t, k> for MultiTypeBlockMatrix (needs some porting work)
- [x] 3aed940 [bugfix] fix broken assertion.
- [x] 1b544df Merge branch 'matrix-loadbalance-to-more' into 'master'
## Merge requests and bugs
- [x] !25 Backport operator[] for MultiTypeBlockVector and MultiTypeBlockMatrix
- [x] !28 Support load balance of global matri from one to more pocesses.DUNE 2.4.1Steffen Müthingsteffen.muething@iwr.uni-heidelberg.deSteffen Müthingsteffen.muething@iwr.uni-heidelberg.dehttps://gitlab.dune-project.org/core/dune-localfunctions/-/issues/1dune-localfunctions 2.4.1 Coordination Task2017-12-03T03:06:23ZSteffen Müthingsteffen.muething@iwr.uni-heidelberg.dedune-localfunctions 2.4.1 Coordination TaskI'll use this task to track the backports for dune-localfunctions 2.4.1.
If you have suggestions for more fixes or concerns about one of the backports, please comment.
## Backported commits
- [x] f6ca4a3 Git ignore build-* inste...I'll use this task to track the backports for dune-localfunctions 2.4.1.
If you have suggestions for more fixes or concerns about one of the backports, please comment.
## Backported commits
- [x] f6ca4a3 Git ignore build-* instead of build-cmake.
- [x] e3fe5c5 [Doxygen] Add subgroups for different element types.
- [x] 6d510d1 Doxygenize the comment on how test-localfe.hh is not part of the public API
- [x] 020905b [autotools] Make configure check work on GCC 4.4
- [x] 4913384 [Bugfix][OSX] only call feenableexcept() on Linux
## Outstanding merge requests and bugsDUNE 2.4.1Steffen Müthingsteffen.muething@iwr.uni-heidelberg.deSteffen Müthingsteffen.muething@iwr.uni-heidelberg.dehttps://gitlab.dune-project.org/core/dune-geometry/-/issues/2dune-geometry 2.4.1 Coordination Task2017-05-21T00:35:09ZSteffen Müthingsteffen.muething@iwr.uni-heidelberg.dedune-geometry 2.4.1 Coordination TaskI'll use this task to track the backports for dune-geometry 2.4.1.
If you have suggestions for more fixes or concerns about one of the backports, please comment.
## Backported commits
- [x] 29a7991 [TypeIndex] Make GlobalGeometr...I'll use this task to track the backports for dune-geometry 2.4.1.
If you have suggestions for more fixes or concerns about one of the backports, please comment.
## Backported commits
- [x] 29a7991 [TypeIndex] Make GlobalGeometryTypeIndex::base() public
- [x] 5807479 [GlobalGeometryTypeIndex] Rename base() to offset()
- [x] 28605aa Git ignore build-* instead of build-cmake.
- [x] b560c20 [autotools] Fix autotools check for dune-geometry on GCC 4.4
- [x] 1b1a273 Fix typo
- [x] a60c5f0 More m4 massaging
- [x] 57ffd59 I hate m4...
- [x] 7757067 Return Jacobian matrix and friends by value
- [x] bb66236 Fix Wshadow warnings
- [x] 133381c [Cleanup] Remove range-based for introduced by backport of 889dd5bd9c
## Outstanding merge requests and bugs
DUNE 2.4.1Steffen Müthingsteffen.muething@iwr.uni-heidelberg.deSteffen Müthingsteffen.muething@iwr.uni-heidelberg.dehttps://gitlab.dune-project.org/core/dune-common/-/issues/17dune-common 2.4.1 Coordination Task2017-06-05T05:56:09ZSteffen Müthingsteffen.muething@iwr.uni-heidelberg.dedune-common 2.4.1 Coordination TaskI'll use this task to track the backports for dune-common 2.4.1.
If you have suggestions for more fixes or concerns about one of the backports, please comment.
## Backported commits
- [x] dd26a82 Merge branch 'feature/dune-proje...I'll use this task to track the backports for dune-common 2.4.1.
If you have suggestions for more fixes or concerns about one of the backports, please comment.
## Backported commits
- [x] dd26a82 Merge branch 'feature/dune-project-indentation' into 'master' (see !18)
- [x] 5b7f8b0 Git ignore build-* instead of build-cmake.
- [x] 68320ae Fix GCC warning by initializing the base class
- [x] d2c7b55 Merge branch 'feature/config.h.cmake-insource'
- [x] dedfa30 [Cmake][cleanup] OverloadCompilerFlags: exec_program --> execute_process.
- [x] a4e62d3 [documentation] minor typo in the documentation of floating comparisons
- [x] 422d6a7 [OverloadCompilerFlags] add EXTRA_CXXFLAGS just in case...
- [x] 71035ad fix typos in comments
- [x] 50a9728 Remove GeometryType section from Doxygen documentation
- [x] 9afe070 INSTALL: Fix typos.
- [x] 8a41b6e [cmake][typetraits][test] Do run the test even with cmake.
- [x] e2afbbf Fix typos
- [x] 8d53f4c Make ReservedVector::max_size() and ::capacity() constexpr
- [x] 9fc5161 Merge branch 'feature/gitlab-readable-contribution-and-licensing-guide' into 'master' (see !5)
- [x] a001f6e [doc] Fix typo in url (cherry picked from commit b5db5759d5bca1abb992a1d98769e67b8aea3a2d)
- [x] 9b55a24 Merge branch 'feature/FS1726-complex-for-fp-only' into 'master' (see !11)
- [x] 2be21a1 use MPI_Get_address instead of MPI_Adress with MPI>=2
- [x] fc74216 use MPI_Type_create_struct instead of MPI_Type_struct with MPI>=2
- [x] da48c09 remove MPI deprectated methods
- [x] 2a51936 [densematrix] reenable and fix broken check, to avoid aliasing in mv and mtv (cherry picked from commit 2abb3bd4f19534e6ba7b43e08d8f102456df8538)
- [x] 9aeb308 Merge branch 'feature/fix-shadow-warnings' into 'master' (see !21)
- [x] 45f52b3 [Cleanup] Revert introduction of range-based for in backported b9deda92a20
- [x] 3395bbc Merge branch 'feature/#5-rightmultiply' into 'master' (see #5, !22)
- [x] d621120 Merge branch 'feature/dunecontrol-less-version-checks' into 'master' (see #9, !28)
- [x] 55babdf Merge branch 'remove_mpi_type_hindexed_warning' into 'master' (see !29)
- [x] 56ed1d1 [Cleanup] Add MPI_2 guard to backported commit dea4e7d0769
- [x] 390378d Remove unnecessary use of the const keyword
- [x] 6467775 Merge branch 'feature/fix-posix_memalign-usage' into 'master'
- [x] 45797c4 Mark destructor of DebugStream as noexcept(false)
- [x] 1b545b3 Merge branch 'bug/cmake-findsuitesparse' into 'master'
- [x] 3125238 Merge branch 'feature/cmake-rewrite-c++-standard-detection' into 'master'
- [x] b1e924e Merge branch 'feature/FS1713-add-config_h-bottom-section' into 'master'
- [x] 4b1fb7c Merge branch 'feature/fix-cmake-documentation-without-doxylocal' into 'master'
- [x] 3b485b9 [cmake][bugfix] Really purge Doxylocal from build system if it wasn't found
## Merge requests and bugs
- [x] !40 Backport suitesparse test to 2.4 (also #14)
- [ ] ~~!42 Disable debugallocator tests on OS X~~
- [x] !43 `mprotect` can only be used for `mmap`'ed memory
- [x] #15 / #16 Handling of newer C++ versions by the build system
- [ ] Maybe #6 MPI_LB and MPI_UB deprecation warnings - if someone provides a patch on master in time
- [x] flyspray/FS#185 Fix building with autotools when no Fortran available
- [x] !46 [CMake] Rewrite C++ standard detection - provided that it gets picked up for `master`
- [x] !47 FindSuiteSparse.cmake: Correct `HAVE_SUITESPARSE_${_component}`
- [x] !19 [cmake] extract bottom block from config.h.cmake
- [x] !60 [scotch] Fixes finding static scotch metis bindings
- [x] !61 [cmake][bugfix] Make CMake Doxygen creation work for modules without DoxylocalDUNE 2.4.1Steffen Müthingsteffen.muething@iwr.uni-heidelberg.deSteffen Müthingsteffen.muething@iwr.uni-heidelberg.dehttps://gitlab.dune-project.org/core/dune-common/-/issues/15Enable C++14 for the 2.4 release branch if it is available2017-06-05T05:56:09ZSteffen Müthingsteffen.muething@iwr.uni-heidelberg.deEnable C++14 for the 2.4 release branch if it is availableThere are already two modules that want C++14 support for 2.4 if possible, `dune-functions` and `dune-pdelab`. Right now, these modules ship local overrides, but the cleaner method would be to integrate the changes into dune-common and p...There are already two modules that want C++14 support for 2.4 if possible, `dune-functions` and `dune-pdelab`. Right now, these modules ship local overrides, but the cleaner method would be to integrate the changes into dune-common and provide the user with an option to disable the C++14 test. See https://gitlab.dune-project.org/pdelab/dune-pdelab/blob/releases/2.4/cmake/modules/PdelabCheckCXX14.cmake for an exampleDUNE 2.4.1https://gitlab.dune-project.org/core/dune-common/-/issues/14Backport new SuiteSparse test to 2.42017-06-05T05:56:11ZSteffen Müthingsteffen.muething@iwr.uni-heidelberg.deBackport new SuiteSparse test to 2.4The existing UMFPack test does not work correctly for newer versions of the library. Fix the problem by backporting the new `FindSuiteSparse.cmake` and `FindUMFPack.cmake` from master and removing the deprecation warning for the latter.The existing UMFPack test does not work correctly for newer versions of the library. Fix the problem by backporting the new `FindSuiteSparse.cmake` and `FindUMFPack.cmake` from master and removing the deprecation warning for the latter.DUNE 2.4.1https://gitlab.dune-project.org/core/dune-common/-/issues/356Follow-up from "Split config file into public and private config files"2023-11-30T18:17:28ZSantiago Ospina De Los Ríossospinar@gmail.comFollow-up from "Split config file into public and private config files"The following discussion from !1262 should be addressed:
- [ ] @mathis.kelm started a [discussion](https://gitlab.dune-project.org/core/dune-common/-/merge_requests/1262#note_132330): (+1 comment)
> @santiago.ospina in DuMux we us...The following discussion from !1262 should be addressed:
- [ ] @mathis.kelm started a [discussion](https://gitlab.dune-project.org/core/dune-common/-/merge_requests/1262#note_132330): (+1 comment)
> @santiago.ospina in DuMux we use definitions like `HAVE_DUNE_FOAMGRID` in our headers. With this change, we've noticed that for dependencies without a `config.h.cmake` file (e.g. dune-subgrid, dune-foamgrid) these definitions are no longer added to the `config.h` file generated for our module. The function `dune_parse_module_config_file` is not called for dependencies without `config.h.cmake` so neither the detection nor the public headers are included in the legacy config header of downstream modules.
> The new config header `include/dumux-config.hh` does try to include public config headers of the dependencies in question, but those are not generated.
>
> Are all DUNE modules expected to have a `config.h.cmake` file now or should at least the detection of dependencies still be included in downstream config headers? Should we make changes in our module?CMake ModernizationSantiago Ospina De Los Ríossospinar@gmail.comSantiago Ospina De Los Ríossospinar@gmail.comhttps://gitlab.dune-project.org/core/dune-common/-/issues/344Split exported targets in module and others2024-03-03T12:51:35ZSantiago Ospina De Los Ríossospinar@gmail.comSplit exported targets in module and othersThe following discussion from !1247 should be addressed:
- [ ] @simon.praetorius started a [discussion](https://gitlab.dune-project.org/core/dune-common/-/merge_requests/1247#note_129102): (+2 comments)
> I think here was a misund...The following discussion from !1247 should be addressed:
- [ ] @simon.praetorius started a [discussion](https://gitlab.dune-project.org/core/dune-common/-/merge_requests/1247#note_129102): (+2 comments)
> I think here was a misunderstanding: "MODULE_LIBRARY" just means that it can be linked by default and is part of DUNE_LIBS, I think. But, if `NO_MODULE_LIBRARY` is set, we do not mean that it should not be exported, it just should not be linked by default to all targets. Example: dunealbertagridXd in dune-grid. This is excluded from the list of module libraries, because we don't know which dimensionworld should be used. This has to be selected by the user when calling `add_dune_alberta_flags`. Now, if it is not a module library, it is not put into the INTERFACE_LIBRARIES set and thus no unscoped targets are created. Thus, dune-grid alberta cannot be used in downstream target. This is just one example, where we can find a fix in dune-grid soon. But in other modules this might be more critical.
>
> We need to merge https://gitlab.dune-project.org/core/dune-grid/-/merge_requests/709 otherwise albertagrid cannot be used.DUNE 2.10.0Santiago Ospina De Los Ríossospinar@gmail.comSantiago Ospina De Los Ríossospinar@gmail.comhttps://gitlab.dune-project.org/core/dune-grid/-/issues/159YaspFixedSizePartioner broken after !6072022-10-17T19:46:20ZTimo KochYaspFixedSizePartioner broken after !607The updates in !607 break downstream code
```
error: cannot declare variable ‘lb’ to be of abstract type ‘Dune::YaspFixedSizePartitioner<1>’
4 169 | Dune::YaspFixedSizePartitioner<dim> lb(partitioning);
5 | ...The updates in !607 break downstream code
```
error: cannot declare variable ‘lb’ to be of abstract type ‘Dune::YaspFixedSizePartitioner<1>’
4 169 | Dune::YaspFixedSizePartitioner<dim> lb(partitioning);
5 | ^~
```
```
/dune/modules/dune-grid/dune/grid/yaspgrid/partitioning.hh:237:84: error: type ‘Dune::YLoadBalanceForward<1>’ is not a direct base of ‘Dune::YaspFixedSizePartitioner<1>’
21 237 | YLoadBalanceForward<d>(std::make_unique<Yasp::FixedSizePartitioning<d>>(dims))
22 | ^
```DUNE 2.9.0Christian EngwerChristian Engwer