Skip to content
Snippets Groups Projects

[cmake] Fix compatibility issue with CMake 3.10 leadig to -D-pthread

Merged Christoph Grüninger requested to merge fix/#34-pthread-from-FindMPI into master
All threads resolved!

CMake 3.10 overhauled FindMPI.cmake. Now -pthread ends in various MPI-related variables and from there in MPI_DUNE_COMPILE_FLAGS. With COMPILE_DEFINITIONS -pthread got the prefix -D. Changed to COMPILE_OPTIONS which does not add -D to the passed flags.

Fixes #34 (closed)

Edited by Christoph Grüninger

Merge request reports

Pipeline #6387 passed

Pipeline passed for 9f1feada on fix/#34-pthread-from-FindMPI

Approval is optional

Merged by Ansgar BurchardtAnsgar Burchardt 7 years ago (Dec 19, 2017 8:12am UTC)

Merge details

Pipeline #6390 passed

Pipeline passed for 0c45c77e on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Other than the above issue, this is exactly the fix I was to apply, if I hadn't been sick in bed.

  • added 1 commit

    • 9f1feada - [cmake] Fix compatibility issue with CMake 3.10 leadig to -D-pthread

    Compare with previous version

  • Christoph Grüninger resolved all discussions

    resolved all discussions

  • mentioned in commit 0c45c77e

  • mentioned in commit f0b87d7c

  • Ansgar Burchardt mentioned in merge request !89 (merged)

    mentioned in merge request !89 (merged)

  • mentioned in commit 6aff7c2d

  • Ansgar Burchardt mentioned in merge request !107 (merged)

    mentioned in merge request !107 (merged)

  • Please register or sign in to reply
    Loading