From 613153331d8e82b32b35cc2d46a8bda69e6af8cc Mon Sep 17 00:00:00 2001
From: Markus Blatt <mblatt@dune-project.org>
Date: Fri, 31 Aug 2012 14:43:59 +0000
Subject: [PATCH] Order matters when providing libs. All symbols used by a
 library must have been already seen by the linker. As DUNE_LIBS (e.g.
 dune-grid) use symbols from other libraries already in ALL_PKG_LIBS (e.g.
 those of the alugrid library), they should be appended to them.

On the other hand libtool removes duplicate libraries provided when
linking from, such that only the first occurence persits. Resulting
e.g. in libalugrid coming after libgrid.

This never caused problems because libtool added dependencies known to
it from the .la file automatically. But it does when using dune core
packages built with cmake (these lack .la files).

All tests of the core module pass (except one in virtual
refinement). Additionally dune-grid-howto build with ug and alugrid enabled.

[[Imported from SVN: r6949]]
---
 m4/dune_all.m4 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/m4/dune_all.m4 b/m4/dune_all.m4
index 64373b3ab..91a02f74a 100644
--- a/m4/dune_all.m4
+++ b/m4/dune_all.m4
@@ -32,7 +32,7 @@ dnl do not use LT_INIT since we want to be compatible with libtool 1.5
   AC_REQUIRE([DUNE_CHECK_MOD_DEPENDENCIES])
 
   # convenience-variables if every found package should be used
-  AC_SUBST([ALL_PKG_LIBS], "$ALL_PKG_LIBS $DUNE_PKG_LIBS $LIBS")
+  AC_SUBST([ALL_PKG_LIBS], "$DUNE_PKG_LIBS $ALL_PKG_LIBS $LIBS")
   AC_SUBST([ALL_PKG_LDFLAGS], "$LDFLAGS $DUNE_PKG_LDFLAGS $ALL_PKG_LDFLAGS")
   AC_SUBST([ALL_PKG_CPPFLAGS], "$CPPFLAGS $DUNE_PKG_CPPFLAGS $ALL_PKG_CPPFLAGS")
   
-- 
GitLab