Skip to content
Snippets Groups Projects

[bugfix][Python] Revert cleanup in locking.py.

Merged [bugfix][Python] Revert cleanup in locking.py.
bugfix/partial-revert-locking into master
All threads resolved!
Merged Robert K requested to merge bugfix/partial-revert-locking into master
All threads resolved!

Fallback implementation for portalocker is still needed.

Edited by Robert K

Merge request reports

Pipeline #41581 passed

Stage: test
Stage: downstream
Pipeline: Dune Nightly Test

#41584

    Pipeline passed for 91ea1984 on bugfix/partial-revert-locking

    Merged by Robert KRobert K 3 years ago (Nov 22, 2021 10:48am UTC)

    Loading

    Pipeline #41587 passed

    Stage: test
    Stage: downstream
    Pipeline: Dune Nightly Test

    #41588

      Pipeline passed for fc5f0397 on master

      Activity

      Filter activity
      • Approvals
      • Assignees & reviewers
      • Comments (from bots)
      • Comments (from users)
      • Commits & branches
      • Edits
      • Labels
      • Lock status
      • Mentions
      • Merge request status
      • Tracking
      • Robert K changed title from [bugfix][Python] Revert cleanup in locking.py. Fallback implementation to [bugfix][Python] Revert cleanup in locking.py.

        changed title from [bugfix][Python] Revert cleanup in locking.py. Fallback implementation to [bugfix][Python] Revert cleanup in locking.py.

      • Robert K enabled an automatic merge when the pipeline for 91ea1984 succeeds

        enabled an automatic merge when the pipeline for 91ea1984 succeeds

      • Robert K merged

        merged

      • Robert K mentioned in commit fc5f0397

        mentioned in commit fc5f0397

      • Timo Koch
        Timo Koch @tkoch ·
        Owner

        How does the (current) installation succeed if portalocker is not found? It's (currently) a hard dependency so the removal was ok. Whether it should be a hard dependency is another question (!1064 (closed)).

        • Robert K
          Robert K @robert.kloefkorn ·
          Author Owner
          Resolved by Timo Koch

          Not sure why it is not recognized, but the removal broke the tool chain on my system. Therefore, I have reverted it temporarily to avoid further troubles. It does not hurt anyway. In general, portalocker is for example not available as a package in gentoo which raises the question on how standard this package actually is and whether it is needed at all. I'm testing this right now.

      • Robert K
        Robert K @robert.kloefkorn ·
        Author Owner

        I suggest to move this discuss somewhere else. This is a closed (merged) MR.

      • Timo Koch resolved all threads

        resolved all threads

      Please register or sign in to reply