Skip to content

Make Python Bindings an optional feature if some requirements are not found

Simon Praetorius requested to merge issue/python-virtualenv-setup-fatalerrors into master

Summary

The python bindings have several direct or indirect requirements, e.g., a virtual env must be build up, pip needs to be found or installed, requirement python packages must be provided... If any of these requirements fails, the python binding could not be installed/used thus should be deactivated. The current behavior is that CMake results in a FATAL_ERROR. This MR changes this to a warning and sets DUNE_ENABLE_PYTHONBINDINGS = OFF in that case. Thus, the regular c++ code can still be compiled and used.

Closes #285 (closed) and #283 (closed)

Edited by Simon Praetorius

Merge request reports