Skip to content

Fix dune_add_pybind11_submodule

Simon Praetorius requested to merge cmake/fix_dune_add_pybind11_submodule into master

This MR fixes the cmake function dune_add_pybind11_submodule, which is essentially just add_library(OBJECT) with some properties explicitly set. This Problem is, that this function must be aligned with all the other add_library functions in dune buildsystem. In this case, some properties were not set properly.

I suggest to deprecate the dune_add_pybind11_submodule and remove it eventually. (Not implemented in this MR) It is much simpler to directly call add_library(OBJECT) and set the properties there.

Close #394 (closed)

Merge request reports