Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
D
dune-common
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 61
    • Issues 61
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 41
    • Merge Requests 41
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Core Modules
  • dune-common
  • Merge Requests
  • !252

Merged
Opened May 20, 2017 by Elias Pipping@pippingDeveloper
  • Report abuse
Report abuse

Remove (index|integer)_sequence fallback to fix #73

  • Overview 4
  • Commits 1
  • Pipelines 1
  • Changes 1

All supported compiler/standard library combinations have it (so that this change does no harm).

Libc++, however, does not declare __cpp_lib_integer_sequence, causing the check to fail and the fallback to be used. This leads to problems because code is already freely mixing Dune::Std::*_sequence and std::*_sequence, expecting them to be the same, which with Libc++ they are not.

Edited Jun 17, 2017 by Elias Pipping
Assignee
Assign to
DUNE 2.5.1
Milestone
DUNE 2.5.1
Assign milestone
Time tracking
1
Labels
bug
Assign labels
  • View project labels
Reference: core/dune-common!252
Source branch: fix/remove-sequence-fallback

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.