[WIP] [FS#1030] Add, use, and test DUNE_ASSERT_BOUNDS

Turning flyspray/FS#1030 (closed) into a merge request to make it easier to view the relevant changes.

To allow an easy hook into the assert I suggest to guard the DUNE_ASSERT_BOUNDS with an #ifndef DUNE_ASSERTS_BOUND

Good idea! I've pushed such a change.

Added 2 commits:

• f2f4e6e2 - Remove unnecessary includes
• c6a4dbe5 - Allow DUNE_ASSERT_BOUNDS to be redefined

The reason that this is still marked as WIP for is: The patchset as it currently stands, does four things:

1. It adds an assertion macro
2. It adds bounds checking to a few functions that currently don't have it
3. It uses the assertion macro instead of custom bounds checking in a few functions
4. It tests all of the above.

What I'm unsure about is the third part: In a few places I'm changing exceptions of type (FMatrixError guarded by DUNE_FMatrix_WITH_CHECKING) into exceptions of type (RangeError guarded by DUNE_CHECK_BOUNDS), e.g. when FieldMatrix::mv checks the dimensions of its arguments. I'm not sure if that's acceptable or even an improvement -- again, the question is if a one-size-fits-all single-argument macro suffices.

Added 1 commit:

• 5b618064 - Do not guard DUNE_UNUSED_PARAMETER

mentioned in merge request !17 (merged)

Status changed to closed