Skip to content
Snippets Groups Projects

Extend jacobian interface of geometry classes

Merged Carsten Gräser requested to merge feature/jacobianinverse into master
All threads resolved!

This adds methods jacobian(local) and jacobianInverse(local) and corresponding typedefs Jacobian and JacobianInverse for the return types to the Geometry interface. More specifically:

  • The new interface is implemented for all Geometry implementations provided by dune-geometry. All implementations return either a FieldMatrix or a DiagonalMatrix by value, even if jacobianTransposed() or jacobianInverseTransposed() provide cached references. Since this only involves transposing the cached matrix, it is still cheap, while not requiring to cache another to matrices.
  • This extends the test checkgeometry.hh by the new interface. This requires that all geometry implementations adopt the new interface as well.
  • By adjusting checkgeometry.hh this implicitly extends the requirements for the grid geometries. But a default implementation is provided there by dune-grid!577 (merged). Hence the latter should be merged before the present MR.

Merge request reports

Pipeline #45700 passed

Pipeline passed for e9a9938f on feature/jacobianinverse

Approval is optional

Merged by Carsten GräserCarsten Gräser 2 years ago (Jun 10, 2022 5:59pm UTC)

Merge details

  • Changes merged into master with b02f8574.
  • Deleted the source branch.

Pipeline #45866 passed

Pipeline passed for b02f8574 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • mentioned in merge request dune-common!1101 (closed)

  • mentioned in merge request dune-common!1138 (merged)

  • Carsten Gräser added 4 commits

    added 4 commits

    • 3be06f84 - Implement jacobian() and jacobianInverse() in AffineGeometry
    • 2a484f35 - Implement jacobian() and jacobianInverse() in (Cached)MultiLinearGeometry
    • d466116c - Implement jacobian() and jacobianInverse() in AxisAlignedCubeGeometry
    • e90c302d - [doc] Mention extended jacobian interface of geometry classes in the change log.

    Compare with previous version

  • Carsten Gräser resolved all threads

    resolved all threads

  • This now relies on dune-common!1138 (merged). There I also pushed a copy of the branch to benefit from branch name matching.

    Edited by Carsten Gräser
  • Carsten Gräser added 13 commits

    added 13 commits

    • e90c302d...96a9468a - 8 commits from branch master
    • b81a8ffa - [test] Add test for jacobian(), jacobianInverse(), and corresponding type defs
    • d7069302 - Implement jacobian() and jacobianInverse() in AffineGeometry
    • f6bc33c5 - Implement jacobian() and jacobianInverse() in (Cached)MultiLinearGeometry
    • fc97468e - Implement jacobian() and jacobianInverse() in AxisAlignedCubeGeometry
    • f28bec74 - [doc] Mention extended jacobian interface of geometry classes in the change log.

    Compare with previous version

  • Carsten Gräser added 5 commits

    added 5 commits

    • 48cbe57b - [test] Add test for jacobian(), jacobianInverse(), and corresponding type defs
    • bf5e28be - Implement jacobian() and jacobianInverse() in AffineGeometry
    • 24faf399 - Implement jacobian() and jacobianInverse() in (Cached)MultiLinearGeometry
    • 9ef54000 - Implement jacobian() and jacobianInverse() in AxisAlignedCubeGeometry
    • e9a9938f - [doc] Mention extended jacobian interface of geometry classes in the change log.

    Compare with previous version

  • Any objections to merging this? It just implements what was decided on the last meeting.

  • mentioned in merge request dune-grid!590 (merged)

  • Carsten Gräser mentioned in commit b02f8574

    mentioned in commit b02f8574

  • Please register or sign in to reply
    Loading