Skip to content
Snippets Groups Projects

Extract the FieldMatrix helper from affine geometry

Open Simon Praetorius requested to merge feature/default-matrix-helper into master
1 unresolved thread

Summary

The FieldMatrixHelper struct provides some special matrix-matrix-vector operations for the matrix appearing in the geometry classes. This helper struct was originally part of the affinegeometry.hh header, but was already used in other geometry implementations. With this MR, we move the implementation into a separate file, clean it up a little and add some documentation.

It would be better to have these functions in dune-common available, but they are very special, e.g., make use of triangular or d´symmetry structure of the matrix. So, also if moved into dune-common they need special names or a new signature. This would be a bigger change and is not proposed here yet.

Edited by Simon Praetorius

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    • e49e8e4d - Remove some changes compared to the old implementation and redirect to existing implementations

    Compare with previous version

  • Simon Praetorius resolved all threads

    resolved all threads

  • 68 {
    69 for( int j = 0; j <= i; ++j )
    70 {
    71 ret[ i ][ j ] = ctype( 0 );
    72 for( int k = 0; k < m; ++k )
    73 ret[ i ][ j ] += A[ k ][ i ] * A[ k ][ j ];
    74 }
    75 }
    76 }
    77
    78 //! Compute A^T*A and store the result in ret
    79 template< int m, int n >
    80 [[ deprecated("Use FMatrixHelp::multTransposedMatrix(A,ret)") ]]
    81 static void ATA ( const FieldMatrix< ctype, m, n > &A, FieldMatrix< ctype, n, n > &ret )
    82 {
    83 return FMatrixHelp::multTransposedMatrix(A,ret);
  • Simon Praetorius mentioned in issue #30

    mentioned in issue #30

  • Simon Praetorius added 74 commits

    added 74 commits

    • e49e8e4d...d3fe49f2 - 72 commits from branch master
    • 379a9b19 - Extract the FieldMatrix helper from affine geometry
    • 38387151 - Remove some changes compared to the old implementation and redirect to existing implementations

    Compare with previous version

  • added 1 commit

    • ef11a0ae - Include recent changes from master

    Compare with previous version

  • added 1 commit

    • 65dd6514 - Use the new header in more geometry implementations

    Compare with previous version

  • Simon Praetorius marked this merge request as ready

    marked this merge request as ready

  • Simon Praetorius changed the description

    changed the description

  • Please register or sign in to reply
    Loading