Skip to content
Snippets Groups Projects

Align leftInvA with rightInvA

Merged Align leftInvA with rightInvA
issue/left-inv into master
All threads resolved!
Merged Simon Praetorius requested to merge issue/left-inv into master
All threads resolved!

Summary

This MR aligns the implementation of leftInvA in the FieldMatrixHelper with that of rightInvA. There, the 2x2 matrix case is extracted. In this MR, I have additionally added the constexpr in the if-clause. I quick benchmark has shown that this results in a 10% faster execution.

Also the leftInvAx is aligned with the xTRightInvA in the return of a bool indicating wither the matrix A^TA is singular.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Simon Praetorius resolved all threads

    resolved all threads

  • Simon Praetorius merged

    merged

  • Simon Praetorius mentioned in commit dbf9bcd1

    mentioned in commit dbf9bcd1

    • Please register or sign in to reply