D

dune-grid

Grid Interface and Implementations

Project ID: 136
  • Oliver Sander's avatar
    [!307] Make Coordinates constructors take domain size instead of element size · 8bb63866
    Oliver Sander authored
    Merge branch 'coordinates-constructors-should-take-domain-size' into 'master'
    
    This patch changes the semantics of the constructors of EquidistantCoordinates
    and EquidistantOffsetCoordinates. Whereas previously they took the element
    size, with the patch they now take the upper right corner of the domain.
    
    Rationale: as of 067abb55 , Coordinates
    objects can be used to construct YaspGrid objects. However, YaspGrid
    constructors expect the upper right domain corner rather than the element
    size. I think being consistent here will help to avoid many mistakes.
    
    Technically, this commit is an interface change. However, I propose to
    fast-track it because while users could use the constructors of the
    Coordinates objects before 067abb55 , they
    couldn't actually do anything with these objects. Therefore I argue that the
    constructors are not really public API after all.
    
    See merge request [!307]
    
      [!307]: gitlab.dune-project.org/core/dune-grid/merge_requests/307
    8bb63866
Name
Last commit
Last update
cmake/modules Loading commit data...
doc Loading commit data...
dune Loading commit data...
lib Loading commit data...
src Loading commit data...
.gitignore Loading commit data...
.gitlab-ci.yml Loading commit data...
CHANGELOG.md Loading commit data...
CMakeLists.txt Loading commit data...
COPYING Loading commit data...
INSTALL Loading commit data...
LICENSE.md Loading commit data...
README.md Loading commit data...
config.h.cmake Loading commit data...
dune-grid.pc.in Loading commit data...
dune.module Loading commit data...