Skip to content

GmshReader: deprecate optional arg that is easy to use incorrectly

Jö Fahlke requested to merge fs1698-deprecate-boundaryless-boundary-data-read into master

In

GmshReader::read(factory, fileName, boundarySegmentToPhysicalEntity,
                 elementToPhysicalEntity, verbose = true,
                 insertBoundarySegments = true)

the default argument insertBoundarySegments is easy to use in the wrong way. If set to false, the data read into the boundarySegmentToPhysicalEntity vector cant be used, as the indexing into that vector happens according to the insertionIndex of the boundary segments, but those were not inserted.

Addresses: flyspray/FS#1698 (closed)

[WIP]:

  • (actually, I may have a better proposal that is more C++17-ish) those are actually proposals that can be done on top
Edited by Jö Fahlke

Merge request reports