Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • D dune-grid
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 46
    • Issues 46
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 23
    • Merge requests 23
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Core ModulesCore Modules
  • dune-grid
  • Merge requests
  • !660

Move ibegin() and iend() from DefaultGridView into GridDefaultImplementation

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Simon Praetorius requested to merge issue/default-gridview-intersection-iterators into master Nov 09, 2022
  • Overview 1
  • Commits 1
  • Pipelines 2
  • Changes 2

Summary

The DefaultGridView is very useful to write grid wrappers easily. The issue is that in the current implementation we still have to implement wrappers for Entities and all what comes with that, since in the ibegin() methods an implementation method of the passed entity is called. Ineatd, this MR moves the ibegin() and iend() methods into the grid implementation as ilevelbegin(), ilevelend() and ileafbegin(), ileafend(). This allows to have a wrapper by just implementing the wrapping grid class and nothing else. This will simplify code a lot. Such a DefaultGridView is already used in some downstream modules, but it would be better to have this directly in dune-grid. Note, this change has no influence on any grid wrapper implementation if it is derived from GridDefaultImplementation where the corresponding methods are added as fallback implementation.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: issue/default-gridview-intersection-iterators