[gmsh] Insert boundary segments for 1d grids (!348) · Merge requests · Core Modules / dune-grid · GitLab

Snippets Groups Projects

An error occurred while fetching the assigned milestone of the selected merge_request.

Merged Timo Koch requested to merge tkoch/dune-grid:feature/gmsh-reader-boundarysegments-1d-grids into master 5 years ago

All threads resolved!

Boundary segments were not inserted for 1d grids (where boundary segments are single nodes). However this is needed to e.g. attach boundary data to a Dune::FoamGrid<1, 3> or Dune::OneDGrid.

Fixes #93 (closed)
Adds a test for 1d gmsh boundary data with OneDGrid

Edited 5 years ago by Timo Koch

Activity

Timo Koch mentioned in merge request extensions/dune-foamgrid!59 (merged) 5 years ago

mentioned in merge request extensions/dune-foamgrid!59 (merged)
Timo Koch @tkoch started a thread on the diff 5 years ago

Resolved 5 years ago by Timo Koch
Last reply by Timo Koch 5 years ago

Timo Koch changed the description 5 years ago

changed the description

Timo Koch @tkoch · 5 years ago

Author Owner

We are testing this with FoamGrid and will report back here if everything works.

Christian Engwer @christi · 5 years ago

Owner

Resolved 5 years ago by Timo Koch

We are testing this with FoamGrid and will report back here if everything works.

It could also be tested with oned grid. Could you ass a test?
Last reply by Timo Koch 5 years ago

Timo Koch added 1 commit 5 years ago

added 1 commit

289a6200 - [test] Add test reading/writing gmsh boundary segments for OneDGrid

Compare with previous version

Timo Koch added 1 commit 5 years ago

added 1 commit

29df76ed - [test] Add test reading/writing gmsh boundary segments for OneDGrid

Compare with previous version

Timo Koch added 1 commit 5 years ago

added 1 commit

efda743a - [test] Add test reading/writing gmsh boundary segments for OneDGrid

Compare with previous version

Timo Koch changed the description 5 years ago

changed the description

Timo Koch resolved all discussions 5 years ago

resolved all discussions

Timo Koch @tkoch · 5 years ago

Author Owner

Ready to be merged from my side.

Oliver Sander @oliver.sander started a thread on an outdated change in commit efda743a 5 years ago

Resolved 5 years ago by Oliver Sander

Timo Koch added 2 commits 5 years ago

added 2 commits

d6a79e9f - [test] Add test reading/writing gmsh boundary segments for OneDGrid
c17c09c5 - [cleanup] Remove trailing whitespace in grid file

Compare with previous version

Timo Koch added 2 commits 5 years ago

added 2 commits

ef0418b9 - [test] Add test reading/writing gmsh boundary segments for OneDGrid
cde03427 - [cleanup] Remove trailing whitespace in grid file

Compare with previous version

Oliver Sander resolved all discussions 5 years ago

resolved all discussions

Oliver Sander enabled an automatic merge when the pipeline for succeeds 5 years ago

enabled an automatic merge when the pipeline for cde03427 succeeds

Oliver Sander merged 5 years ago

merged

Oliver Sander mentioned in commit 5 years ago

mentioned in commit eaadf1b1

Timo Koch mentioned in commit 5 years ago

mentioned in commit extensions/dune-foamgrid@a5649061

Please register or sign in to reply