solverfactorytest: range-based for loops with const references

This is less about performance and mor about silencing
the Clazy warnings.
Found by Clazy (range-loop-reference)