Skip to content
Snippets Groups Projects
  1. Mar 29, 2020
    • Oliver Sander's avatar
      Rewrite doc of the BCRSMatrix 'implicit' build mode · a1feed88
      Oliver Sander authored
      Circumstances forced me to finally learn what the BCRSMatrix 'implicit'
      build mode really does, and where its limitations come from.  I had
      to read the code for that.  As it turns out, the documentation of the
      mode is quite misleading.  My main gripe is that the code uses two
      different auxiliary data structures, but the documentation calls them
      both 'overflow'.  This problem even extends to the variable naming
      in the code.  Behold: the parameter 'overflowsize' is NOT the size
      of the member 'overflow'.  It doesn't even have anything to do with
      that member...
      
      To improve the situation, this patch does three things:
      a) It rewrites the documentation.  In particular, the 'overflow area'
         is now clearly distinguished from the 'compression buffer'.
         The latter is a new word I introduce.
      b) It renames the BCRSMatrix method parameter _overflowsize to
         compressionBufferSize, because that is what it is:  That parameter
         has nothing to do with the 'overflow' data member, or even the
         concept of 'overflowing' in general.
      c) It renames the exception 'ImplicitModeOverflowExhausted' to
         'ImplicitModeCompressionBufferExhausted', for the same reason.
         This is the only interface changes.  The code keeps the old
         exception for backward-compatibility, but makes it trigger a
         deprecation warning.
      a1feed88
  2. Mar 20, 2020
    • Oliver Sander's avatar
      [!366] CHOLMOD: provide access to the cholmod_common object · de175a9f
      Oliver Sander authored
      Merge branch 'feature/cholmod-common' into 'master'
      
      ref:core/dune-istl\> This allows other implementations that are using the
      istl-cholmod wrapper to set options and other parameters of the cholmod
      solver.
      
      See merge request [!366]
      
        [!366]: gitlab.dune-project.org/core/dune-istl/merge_requests/366
      de175a9f
  3. Mar 19, 2020
  4. Mar 16, 2020
  5. Mar 11, 2020
  6. Mar 06, 2020
  7. Mar 05, 2020
  8. Feb 26, 2020
  9. Feb 10, 2020
  10. Jan 29, 2020
  11. Jan 26, 2020
    • Markus Blatt's avatar
      [!350] Solver factory: correct naming scheme and typos · b7234114
      Markus Blatt authored
      Merge branch 'feature/solver-factory-naming-schemes' into 'master'
      
      ref:core/dune-istl Apply naming schemes to solver factory function, improve
      some internal variable names and correct some spelling and grammar mistakes.
      
      The most severe issue fixed:
      
      -   the functions default_preconditoner_BL_creator and
          default_preconditoner_creator didn't comply with the naming scheme and
          also had a spelling mistake: missing i in preconditoner.
      -   in the usage of registry_put the name didn't make it clear that it is a
          macro. Also the macro should definitely be prefixed with DUNE to avoid
          conflicts with other libraries -\> changed to DUNE_REGISTRY_PUT.
      
      @gruenich Should probably be fixed before the release 2.7 so we don't need to
      deprecate the names.
      
      See merge request [!350]
      
        [!350]: gitlab.dune-project.org/core/dune-istl/merge_requests/350
      b7234114
    • Markus Blatt's avatar
      [!357] [solver factory] configure coarsen criterion from the parameter tree · 9e71807e
      Markus Blatt authored
      Merge branch 'feature/factory-determine-amg-criterion' into 'master'
      
      ref:core/dune-istl Note that this changes the default criterion to the
      symmetric one that uses FirstDiagonal for computing strength of connection.
      Previously it was the unsymmetric one with rowSum.
      
      Note also that the new default will not work for complex.
      
      Closes [#85]
      
      See merge request [!357]
      
        [#85]: gitlab.dune-project.org/NoneNone/issues/85
        [!357]: gitlab.dune-project.org/core/dune-istl/merge_requests/357
      
      
      Closes #85
      9e71807e
    • Markus Blatt's avatar
      [solver factory] configure coarsen criterion from the parameter tree · 4612afd0
      Markus Blatt authored
      Note that this changes the default criterion to the symmetric one that
      uses FirstDiagonal for computing strength of connection. Previously it
      was the unsymmetric one with rowSum.
      
      Note also that the new default will not work for complex.
      4612afd0
  12. Jan 23, 2020
    • Markus Blatt's avatar
      [!348] Make NonoverlappingOperator work with BCRSMatrix of pods. · 88382dca
      Markus Blatt authored
      Merge branch 'feature/novlap-scalar' into 'master'
      
      ref:core/dune-istl This should make support for scalar matrices more complete.
      Sequentially these matrices work, also for the overlapping case. It is just
      the nonoverlapping that was missed.
      
      @gruenich Your choice whether this is release material. Either PdeLab does not
      use scalar matrices yet, or nobody tested the non-overlapping stuff with it.
      
      @oliver.sander Can you check, whether I used the Hybrid stuff correctly? I
      just looked at your changes to gsetc.hh as an example for this.
      
      See merge request [!348]
      
        [!348]: gitlab.dune-project.org/core/dune-istl/merge_requests/348
      88382dca
    • Markus Blatt's avatar
      Make NonoverlappingOperator work with BCRSMatrix of pods. · c620c02c
      Markus Blatt authored
      This should make support for scalar matrices more complete.
      c620c02c
Loading