umfpacktest.cc does not compile if umfpack is present but not suitesparse

As far as I understand the test the problem is the following:

In this case the test defined SuiteSparse_UMFPACK_FOUND which activates the test.

On the other hand HAVE_SUITESPARSE_UMFPACK which is checked in our umfpack.hh is set to ENABLE_SUITESPARSE in config.h. This, however, is only set if SuiteSparse_FOUND is true.

Another problem related to this:

As far as I can see umfpackamgtest and umfpackfastamgtest are silently using BICGSTAB as coarse solver in the above described situation.

Added bug label

Added buildsystem label

The AMG problem is AMG-inherent: It is AMGs policy to do so if neither UMFPack nor SuperLU is found on the system. I am all for discussing whether requiring one of these for AMG is a good idea.

Reassigned to @gruenich

Milestone changed to DUNE 3.0.0

I'll solve the initial issue within flyspray/FS#1538 (closed).

@gruenich: That's great.

But to avoid confusion: This is not just a problem of not skipping the test. (I have already patched it locally to do so.) The main problem is that the results of the suitesparse test are inconsistent.

Check out the branch feature/FS-1538-build-and-mark-skipped-tests. I'll have to fix the two other test directories before merging.

@gruenich: now that feature/FS-1538-build-and-mark-skipped-tests is merged, is this issue fixed?

I never had a problem. @carsten.graeser can you close this, if it works for you?

@gruenich flyspray/FS#1538 (closed) and this one are unrelated (and Carsten also stated so).

I thought I fixed, too. If this is not the case, Casten can merge request his local patch.

Yes, as expected, the build does no longer fail when properly skipping the test. (My local patch did the same.) However, this bug was only the symptom of the underlying problem that the results of the suitesparse test are inconsistent. This issue is still present.

Another symptom of the same problem is, that the umfpackamgtest still compiles and runs but without using umfpack, although umfpack is installed.

Ok, sorry for the confusion and thanks for the clarification. I'll have another look.

Found the problem, FindSuiteSparse.cmake does not set HAVE_UMFPACK. Opened according merge request in dune-common.

mentioned in merge request dune-common!30 (merged)

Fixed in dune-common with dune-common!30 (merged)

Status changed to closed