Skip to content

[Clang] Fix warning about an unchecked enumerator in switch().

Jö Fahlke requested to merge fix-unchecked-enum-warning into master 
/home/joe/Projekte/dune-simd/dune-istl/dune/istl/matrixmarket.hh:706:18: warning: enumeration values 'general' and 'unknown_structure' not handled in switch [-Wswitch]
          switch(mmHeader.structure)
  • Move the switch(mmHeader.structure) out of the loop over the entries and and check all structure types there. This will throw immediately for unknown structure types, rather then reading all entries and then throwing.
  • Write the for() loop in a less unusual format; i.e. don't try and save on local integer variables.

Merge request reports