Fix #68

added 14 commits

• 78351883 - execute parallelamgtest also for multiple ranks
• 0ac8c227 - Simplify scalar entries in block vector classes
• 122cc075 - Add missing include
• 14ae4949 - Get rid of toVector()
• 1d338446 - Replace toMatrix() by asMatrix() from dune-common
• 33f142cc - Remove toMatrix()
• 77ce4eca - Add missing include
• ddd32c91 - Simplify implementation using Impl::asMatrix()
• 609fbed4 - Simplify code using Impl::asMatrix()
• 109c5163 - Simplify loops using range based for
• 8da68b2f - Simplify BTDMatrix::solve() using Impl::asMatrix() and Impl::asVector()
• 972907ec - [fix] operator should store the matrix as shared_ptr
• 196f2a02 - [fix] don't try to delete objects managed by shared_ptr.
• 8cfa47ea - include missing header

Compare with previous version

marked as a Work In Progress

most of the test run through now... only pamgtest-mpi-4 seems to fail. At least this was the status on my local machine.

Update: The problem seems to be that I don't have sufficiently many MPI ranks configured. So let's see whether the test run through...

unmarked as a Work In Progress

mentioned in issue #68 (closed)

Can we also run the other pamg mpi tests in parallel? see 9f2c10c7

Edit: I think we should, the galerkin test still segfaults in parallel.

--------------------------------------------------------------------------
21: mpiexec noticed that process rank 0 with PID 0 on node pumbaa exited on signal 11 (Segmentation fault).
21: --------------------------------------------------------------------------
1/1 Test #21: galerkintest-mpi-2 ...............***Failed    1.41 sec

Should the operator constructors taking references be deprecated in favor of the shared_ptr constructors then?

I think this should be std::shared_ptr<const matrix_type> as well as the private member below, no? To match the const matrix_type&.

I get the following compiler error in my code:

/home/timok/dumux-dune-master/dune-istl/dune/istl/novlpschwarz.hh:92:78: error: no matching function for call to 'std::shared_ptr<Dune::BCRSMatrix<Dune::FieldMatrix<double, 1, 1>, std::allocator<Dune::FieldMatrix<double, 1, 1> > > >::shared_ptr(std::shared_ptr<const Dune::BCRSMatrix<Dune::FieldMatrix<double, 1, 1>, std::allocator<Dune::FieldMatrix<double, 1, 1> > > >)'
       : _A_(stackobject_to_shared_ptr(A)), communication(com), buildcomm(true)
                                                                              ^

I fixed this in !294 (merged) (I don't have the rights to push here so I opened a new MR)

std::shared_ptr<const matrix_type>

I fixed this in !294 (merged)

galerkintest issue confirmed. But today I don't have time to look into this...

I looked into it again. The galerkintest failure is an unrelated issue. It already exists on release/2.6, I'll open an issue (#70)

Hi guys, this MR fixes a crash in my code that I encountered recently. Please merge soonish. Thanks!

@oliver.sander This MR in completed in !294 (merged). !294 (merged) Should be ready to merge. I had to open a new MR because I'm not allowed to push here. You could assign @christi to !294 (merged), or merge yourself.

superseeded by !294 (merged) ...

closed