Skip to content

[!350] Solver factory: correct naming scheme and typos

Markus Blatt requested to merge cherry-pick-b7234114 into releases/2.7

Merge branch 'feature/solver-factory-naming-schemes' into 'master'

ref:core/dune-istl Apply naming schemes to solver factory function, improve some internal variable names and correct some spelling and grammar mistakes.

The most severe issue fixed:

  • the functions default_preconditoner_BL_creator and default_preconditoner_creator didn't comply with the naming scheme and also had a spelling mistake: missing i in preconditoner.
  • in the usage of registry_put the name didn't make it clear that it is a macro. Also the macro should definitely be prefixed with DUNE to avoid conflicts with other libraries -> changed to DUNE_REGISTRY_PUT.

@gruenich Should probably be fixed before the release 2.7 so we don't need to deprecate the names.

See merge request core/dune-istl!350

(cherry picked from commit b7234114)

8843c372 [solverfactory] Use camelCase for creator functions dd28a082 [solverfactory] Use self-explanatory variable names 57aa5e18 [solverfactory] Correct spelling and grammar a747993d [registry] Use camelCase naming convention 1f7eb355 [registry] Use macro naming convention for registry put macro

Merge request reports