[bugfix] Produce a linker error when pardiso lib is not found
If somebody tries to use pardiso despite it not being found, he should ge t a linker error instead of an exception. All other bindings handle it that way.
Fixes flyspray/FS#351 (closed)
Merge request reports
Activity
Added 1 commit:
- 83aa41e1 - [fixup] correctly nest namespace and ifdef directive
Reassigned to @bernd.flemisch
I took a look at it. It seems that SeqPardiso has not been tested for a long time, since it was neither compatible with current ISTL nor current Pardiso. The attached patch would solve this issue. If applied, everything works as expected: compilation failure if HAVE_PARDISO is 0, successful test if Pardiso is available.
A decision should be made if Pardiso should be supported in the future. If yes, I would volunteer to get rid of two remaining shortcomings:
- no proper CMake detection
- only applicable to scalar systems (we already have a more general form in Dumux)
0001-pardiso-update-the-Pardiso-preconditioner-to-current.patch
Added 1 commit:
- 651408f1 - [pardiso] update the Pardiso preconditioner to current Dune and Pardiso versions
@bernd.flemisch I have applied your patch to this branch. Btw, you have developer rights in the core modules, you could have pushed it yourself! That is the nice thing about feature branches and merge requests, you do not need to be restrictive with the
developer
status, only with themaster
status.I will merge this for now. @bernd.flemisch do you want to open an issue for the future of pardiso?
mentioned in commit bc96b0d3