Move various implementation classes into the 'Imp' namespace

There are various classes in dune-istl that are effectively implementation classes internal to dune-istl. A few of them are base_array_unmanaged, base_array_window, compressed_base_array_unmanaged,block_vector_unmanaged, BlockVectorWindow, compressed_block_vector_unmanaged, CompressedBlockVectorWindow

See #22 for a brief discussion.

This patch moves the classes into the namespace 'Imp'. That way it is clear that they are internal.

All code outside of dune-istl using those classes will break, but does such code really exist?

Mentioned in issue #22

Milestone removed

BTW, is there an official ruling on whether the special internal namespace is called 'Imp' or 'Impl'? I have seen both in the core modules.

No, we did not decide this. But since this is not part of the interface we're free to change this any time. I've also seen Detail as implementation namespace.

I don't have any preference regarding Imp, Impl, Detail. But if we agree on one of these, it will save me a few seconds of thinking about which one to use in a new header and another few seconds each time I have to look up which one is used in a header.

I don't have any preference regarding |Imp|, |Impl|, |Detail|. But if we agree on one of these, it will save me a few seconds of thinking about which one to use in a new header and another few seconds each time I have to look up which one is used in a header.

Exactly. That's why I ask.

signature.asc

I don't have any preference regarding Imp, Impl, Detail. But if we agree on one of these, it will save me a few seconds of thinking about which one to use in a new header and another few seconds each time I have to look up which one is used in a header.

I'd prefer "Impl", but could live with the other decisions as well.

I second that we should decide on a general guideline for such namespaces. Besides the problems about remembering the correct namespace, I also observed issues in a small project with code analysis. In such cases a proper naming scheme would also make life easier.

Impl is my favorite, too, but it is of no importance to me.

"Imp" remindes me on http://de.gameofthrones.wikia.com/wiki/Tyrion_Lennister instead of an implementation namespace ;-)

I'd vote for Inpl (don't like Imp much, detail or Detail is also fine).

Neither Imp or Impl are very clear. Since the purpose is to mark classes as internal I think the namespace should be internal or something more precise.

It seems that outside of the dune world 'detail' is popular. Since this already turned from a discussion to a vote, let's try using our new voting system: https://discourse.dune-project.org/t/naming-convention-for-implementation-namespace/54

I don't have access - gives me Sorry, you don't have access to that topic! Andreas

Added 15 commits:

• 8649fc02...e50c4952 - 14 commits from branch master
• 13ec7d1b - Move various implementation classes into the 'Imp' namespace

Compare with previous version

Enabled an automatic merge when the build for 13ec7d1b succeeds

Mentioned in commit ec617e3b

Status changed to merged

mentioned in issue dune-grid#58