Skip to content

Merge branch 'feature/remove-forbidden-downcast' into 'master'

Markus Blatt requested to merge cherry-pick-d487fef6 into releases/2.5

Remove forbidden downcast

This removes several constructors and assignments from base class in the class hierarchy around base_array. These removed methods are all implemented using a downcast which may result in undefined behaviour. Since they are not used anywhere in the core modules we can maybe remove them. According to @markus.blatt these base classes are all meant to be internal.

This may cause problems if user code explicitly uses the raw base classes and these methods. However, such user code would only be valid if the passed base class reference is actually an upcasted derived class which is very unlikely.

See merge request !66 (merged)

Merge request reports

Loading