Skip to content
Snippets Groups Projects

Feature/fgmres

Merged Timo Koch requested to merge tkoch/dune-istl:feature/fgmres into master

Implements a right-preconditioned flexible GMRes solver.

Edited by Timo Koch

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Christian Engwer
  • Christian Engwer
  • Timo Koch added 93 commits

    added 93 commits

    • 1d014192...676d3a38 - 91 commits from branch core:master
    • a4174df6 - [gmres][bugfix] Fix double call of prec->post(x) when res is zero
    • ff03da48 - [fgmres] Implement a right-preconditioned flexible GMRes solver

    Compare with previous version

  • Timo Koch resolved all discussions

    resolved all discussions

  • Seems like there is a bugfix hidden in this feature MR. Shouldn't we split this up?

  • Author Owner

    Yes you're right I'll split it up.

  • Timo Koch added 48 commits

    added 48 commits

    Compare with previous version

  • Timo Koch changed the description

    changed the description

  • Author Owner

    I opened !172 (merged) for the gmres bugfix

    Edited by Timo Koch
  • Is this ready for merge?

  • Author Owner

    yes but it should maybe be checked by someone with solver knowledge.

  • Could you rebase on top of the current master?

  • Timo Koch added 26 commits

    added 26 commits

    Compare with previous version

  • Great. There is only one thing I have to complain about. RestartedGMResSolver RestartedfGMResSolver

    These two solvers names only differ in one small letter in the middle of the word. I think this is not good because it's hard to read. Should be something like RestartedFlexibleMResSolver or similar to make the difference more visible.

  • Timo Koch added 1 commit

    added 1 commit

    • 3a5a43ce - [fgmres] Implement a right-preconditioned flexible GMRes solver

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading