1. 05 Apr, 2020 3 commits
    • Andreas Dedner's avatar
      [!374] missing APPEND in add_library for python target added · da53c670
      Andreas Dedner authored
      Merge branch 'bugfix/MissingAppend' into 'master'
      
      See merge request [!374]
      
        [!374]: Nonecore/dune-istl/merge_requests/374
      da53c670
    • Andreas Dedner's avatar
      344a83bf
    • Oliver Sander's avatar
      [!370] Rewrite doc of the BCRSMatrix 'implicit' build mode · 95b8fa3c
      Oliver Sander authored
      Merge branch 'explain-implicit-buildmode' into 'master'
      
      ref:core/dune-istl\> Circumstances forced me to finally learn what the
      BCRSMatrix 'implicit' build mode really does, and where its limitations come
      from. I had to read the code for that. As it turns out, the documentation of
      the mode is quite misleading. My main gripe is that the code uses two
      different auxiliary data structures, but the documentation calls them both
      'overflow'. This problem even extends to the variable naming in the code.
      Behold: the parameter 'overflowsize' is NOT the size of the member 'overflow'.
      It doesn't even have anything to do with that member\...
      
      To improve the situation, this patch does three things:
      
      1.  It rewrites the documentation. In particular, the 'overflow area' is now
          clearly distinguished from the 'compression buffer'. The latter is a new
          word I introduce.
      
      2.  It renames the BCRSMatrix method parameter _overflowsize to
          compressionBufferSize, because that is what it is: That parameter has
          nothing to do with the 'overflow' data member, or even the concept of
          'overflowing' in general.
      
      3.  It renames the exception 'ImplicitModeOverflowExhausted' to
          'ImplicitModeCompressionBufferExhausted', for the same reason. This is the
          only interface changes. The code keeps the old exception for
          backward-compatibility, but makes it trigger a deprecation warning.
      
      See merge request [!370]
      
        [!370]: gitlab.dune-project.org/core/dune-istl/merge_requests/370
      95b8fa3c
  2. 04 Apr, 2020 6 commits
    • Christoph Grüninger's avatar
      [!372] Fix make build_tests without optional dependencies · 9635a36e
      Christoph Grüninger authored
      Merge branch 'fix/non-mpi-build' into 'master'
      
      ref:core/dune-istl\> When MPI is not available or explicitly disabled with the
      CMake build option -DCMAKE_IDSABLE_FIND_PACKAGE_MPI=TRUE, some tests were
      unable to build. I've either fixed or disabled those tests (for those tests
      that were testing MPI-only features).
      
      I've also fixed overlappingschawarztest, which did not build when SuperLU was
      not found.
      
      The commit concerning MPI should probably be backported to the releases/2.7
      branch, as it is affected by the same build failures. The fix for
      overlappingschwarztest only appeared after commit
      05f80ffa which fixed a bug which previously
      disabled the test. Since this commit is not on the releases/2.7 branch, there
      is probably no need to backport my fix for overlappingschwarztest.
      
      See merge request [!372]
      
        [!372]: gitlab.dune-project.org/core/dune-istl/merge_requests/372
      9635a36e
    • Felix Gruber's avatar
      overlappingschwarztest: remove broken runtime check · e5ead46f
      Felix Gruber authored
      This test should not be necessary anymore, since commit
      05f80ffa fixed the CMAKE_GUARD argument
      for this test, so that it is not compiled anymore if either UMFPACK or
      SuperLU are missing.
      
      That line had to be removed as it did not compile if either UMFPACK or
      SuperLU were missing. For example while I had UMFPACK installed but not
      SuperLU, gcc gave me the following error message for the removed line:
      
      …/dune/istl/test/overlappingschwarztest.cc:260:17: error: ‘HAVE_SUPERLU’ was not declared in this scope
      e5ead46f
    • Andreas Dedner's avatar
      [!369] Feature/add python bindings · d645bec5
      Andreas Dedner authored
      Merge branch 'feature/addPythonBindings' into 'master'
      
      See merge request [!369]
      
        [!369]: Nonecore/dune-istl/merge_requests/369
      d645bec5
    • Felix Gruber's avatar
      make tests succeed when MPI is disabled · be46d889
      Felix Gruber authored
      When MPI is not available or explicitly disabled with the CMake build
      option -DCMAKE_IDSABLE_FIND_PACKAGE_MPI=TRUE, some tests were unable to
      build.
      
      The tests created from solverfactorytest.cc.in and part of
      scalarproductstest.cc use Dune::OwnerOverlapCopyCommunication which is
      defined behind `#if HAVE_MPI` and is thus not available in a non-MPI
      build. I've thus disabled those tests when MPI is unavailable.
      
      The matrixmarkettest did not work without MPI, as it contained some code
      using the wrong template parameters when HAVE_MPI was not set. Those
      template paramters have been fixed now.
      
      I've confirmed, that after my changes `make build_tests` succeeds to
      build all tests and that those tests run without failure.
      be46d889
    • Andreas Dedner's avatar
    • Andreas Dedner's avatar
      f699b101
  3. 03 Apr, 2020 1 commit
  4. 30 Mar, 2020 2 commits
  5. 29 Mar, 2020 1 commit
    • Oliver Sander's avatar
      Rewrite doc of the BCRSMatrix 'implicit' build mode · a1feed88
      Oliver Sander authored
      Circumstances forced me to finally learn what the BCRSMatrix 'implicit'
      build mode really does, and where its limitations come from.  I had
      to read the code for that.  As it turns out, the documentation of the
      mode is quite misleading.  My main gripe is that the code uses two
      different auxiliary data structures, but the documentation calls them
      both 'overflow'.  This problem even extends to the variable naming
      in the code.  Behold: the parameter 'overflowsize' is NOT the size
      of the member 'overflow'.  It doesn't even have anything to do with
      that member...
      
      To improve the situation, this patch does three things:
      a) It rewrites the documentation.  In particular, the 'overflow area'
         is now clearly distinguished from the 'compression buffer'.
         The latter is a new word I introduce.
      b) It renames the BCRSMatrix method parameter _overflowsize to
         compressionBufferSize, because that is what it is:  That parameter
         has nothing to do with the 'overflow' data member, or even the
         concept of 'overflowing' in general.
      c) It renames the exception 'ImplicitModeOverflowExhausted' to
         'ImplicitModeCompressionBufferExhausted', for the same reason.
         This is the only interface changes.  The code keeps the old
         exception for backward-compatibility, but makes it trigger a
         deprecation warning.
      a1feed88
  6. 27 Mar, 2020 7 commits
  7. 20 Mar, 2020 1 commit
    • Oliver Sander's avatar
      [!366] CHOLMOD: provide access to the cholmod_common object · de175a9f
      Oliver Sander authored
      Merge branch 'feature/cholmod-common' into 'master'
      
      ref:core/dune-istl\> This allows other implementations that are using the
      istl-cholmod wrapper to set options and other parameters of the cholmod
      solver.
      
      See merge request [!366]
      
        [!366]: gitlab.dune-project.org/core/dune-istl/merge_requests/366
      de175a9f
  8. 19 Mar, 2020 2 commits
  9. 16 Mar, 2020 1 commit
  10. 11 Mar, 2020 16 commits