Skip to content
GitLab
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    Projects Groups Snippets
  • Sign up now
  • Login
  • Sign in
  • D dune-localfunctions
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 8
    • Issues 8
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 8
    • Merge requests 8
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Core ModulesCore Modules
  • dune-localfunctions
  • Merge requests
  • !137

Deprecate duck-typed constructor from Lagrange element

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Dominic Kempf requested to merge feature/deprecate-ducktype-interface-method into master Aug 27, 2019
  • Overview 2
  • Commits 1
  • Pipelines 1
  • Changes 1

The constructor of the Lagrange element which is provided a vertex permutation previously accepted this in a duck-type fashion through a template parameter. The reimplementation by @oliver.sander internally works with std::array<unsigned int, dim + 1> which seems the correct call to me as well.

I therefore propose to fix this type in the interface, deprecating the old constructor. Most likely, only maintainers of discretization packages are affected by this change.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: feature/deprecate-ducktype-interface-method