[test] Cleanup lagrangeshapefunctiontest
On the one hand the test so far checked several LFE implementations
twice, on the other hand, some (e.g. higher order in 1d) where not
checked sufficiently. This patch unifies the checks among all checked
Lagrange LFE implementations including several cases missing before
and making use of Dune::TestSuite
.
Furthermore all checked LFE implementations are now also checked when
wrapped once or twice in the virtual wrapper. While the compile time
is increased due to the increased coverage, it's still moderate.
Merge request reports
Activity
@gruenich You're the last person who did a functional change to this test. Can you have a look?
mentioned in merge request !296 (merged)
I'd rather add this separately. The present MR just cleans up the existing tests and adds missing combinations in the matrix.
When adding more dimension to this (e.g. different field types) we may also evaluate which cases should be tested. Notice that the runtime of the test is fine, but compilation already takes quite a bit of time.
Currently
testFE()
does not compile at all withFloat128
orGMPField<128>
. With some patches I can fix this and the tests pass withFloat128
. But forGMPField<128>
I get a segfault. Hence my patches may be incomplete. This needs to be carefully investigated.Since making
testFE()
work with other types thandouble
is not the scope of this MR it should be done separately. Once it works we can easily call this from the cleaned uplagrangeshapefunctiontest
.
mentioned in commit a798d7f4