1. 10 Jan, 2019 2 commits
    • Carsten Gräser's avatar
      [!115] Disable floating point exceptions for clang · 9c04ebe1
      Carsten Gräser authored
      Merge branch 'feature/disable-fp-exception-with-clang' into 'master'
      
      ref:core/dune-localfunctions When compiling with -O3 clang versions \>= 5.0
      may generate code containing auxiliary operations dividing by zero altough the
      result is not used. Specifically code like this
      
          for (int i=0; i<=3; i++)
            for (int j=0; j<=3; j++)
              for (int k=0; k<=3; k++)
                if ((m!=i) && (m!=j) && (m!=k))
                  z += x*(1.0/(m-k))*(1.0/(m-j))*(1.0/(m-i));
      
      should never devide by zero. While the result of the code is correct with
      clang, it seems to produce additional operations for the ruled out cases where
      we would devide by zero. For more details see the clang bug:
      [https://bugs.llvm.org/show_bug.cgi?id=40280]
      
      The only possible solution on our side is to turn of FP exceptions for clang.
      This hoefully fixes [#13].
      
      See merge request [!115]
      
        [https://bugs.llvm.org/show_bug.cgi?id=40280]: https://bugs.llvm.org/show_bug.cgi?id=40280
        [#13]: gitlab.dune-project.org/NoneNone/issues/13
        [!115]: gitlab.dune-project.org/core/dune-localfunctions/merge_requests/115
      
      
      Closes #13
      9c04ebe1
    • Carsten Gräser's avatar
      Disable floating point exceptions for clang · 0bb9ba40
      Carsten Gräser authored
      When compiling with `-O3` clang versions >= 5.0 may
      generate code containing auxiliary operations dividing
      by zero altough the result is not used. Specifically code like this
      
      ```cpp
      for (int i=0; i<=3; i++)
        for (int j=0; j<=3; j++)
          for (int k=0; k<=3; k++)
            if ((m!=i) && (m!=j) && (m!=k))
              z += x*(1.0/(m-k))*(1.0/(m-j))*(1.0/(m-i));
      ```
      
      should never devide by zero. While the result of the code
      is correct with clang, it seems to produce additional
      operations for the ruled out cases where we would devide by zero.
      For more details see the clang bug: https://bugs.llvm.org/show_bug.cgi?id=40280
      
      The only possible solution on our side is to turn of FP exceptions
      for clang.
      0bb9ba40
  2. 31 Dec, 2018 2 commits
  3. 29 Dec, 2018 1 commit
  4. 16 Dec, 2018 4 commits
  5. 06 Dec, 2018 3 commits
  6. 02 Jul, 2018 1 commit
  7. 26 Apr, 2018 2 commits
  8. 25 Apr, 2018 2 commits
    • Ansgar Burchardt's avatar
      Merge branch 'feature/do-not-catch-polymorphic-type' into 'master' · d17214fc
      Ansgar Burchardt authored
      do not catch exceptions in main()
      
      See merge request !107
      d17214fc
    • Ansgar Burchardt's avatar
      do not catch exceptions in main() · 497d7846
      Ansgar Burchardt authored
      An uncaught exception will result in the test failing.  There is no
      need to explicitly catch them.
      
      Removing the exception handler also addresses the following compiler
      warnings from GCC 8:
      
          test-biorthogonality.cc:215:23: warning:
          catching polymorphic type ‘class Dune::Exception’ by value [-Wcatch-value=]
      
          refinedelementtest.cc:34:24: warning:
          catching polymorphic type ‘class Dune::Exception’ by value [-Wcatch-value=]
      
          brezzidouglasmarinielementtest.cc:37:24: warning:
          catching polymorphic type ‘class Dune::Exception’ by value [-Wcatch-value=]
      
          rannacherturekelementtest.cc:26:24: warning:
          catching polymorphic type ‘class Dune::Exception’ by value [-Wcatch-value=]
      
          virtualshapefunctiontest.cc:160:18: warning:
          catching polymorphic type ‘class Dune::Exception’ by value [-Wcatch-value=]
      
          raviartthomaselementtest.cc:53:24: warning:
          catching polymorphic type ‘class Dune::Exception’ by value [-Wcatch-value=]
      
          hierarchicalelementtest.cc:35:24: warning:
          catching polymorphic type ‘class Dune::Exception’ by value [-Wcatch-value=]
      497d7846
  9. 13 Apr, 2018 2 commits
  10. 09 Apr, 2018 2 commits
  11. 08 Apr, 2018 19 commits