Resolve "Add scaling field input"
What does this MR do?
Add option to input global Miller scaling fields and supply framework for generalized scaling field input
-
Revamp interpolators to be more generic and hold actual data -
Add base class and factory -
Add Nearest-Neighbor interpolator -
[ ] Have interpolators implementGridFunctionBase
Not possible because current interface does not supply the necessary grid view.
-
Add unit test for interpolator
-
-
Add adapters for evaluating scaling factors -
Add base class and factory -
Add dummy scaling adapter -
Add Miller scaling adapter -
[ ] Have scaling adapters implementGridFunctionBase
Not possible because current interface does not supply the necessary grid view.
-
Add unit test for scaling adapter
-
-
Add infrastructure -
Add section to documentation of soil parameters and architecture -
Add ExponentialConverter
with parameters tofield-parameters.xml
-
Add parameterization file param.yml
todefault_files
-
-
Rewrite test-parameterization
not to useRichardsSimulation
anymore. -
Add unit test test-parameterization-scaled
, ensuring that scaling is correctly applied wrt. the regular parameterization.
Is there something that needs to be double checked?
-
test-parameterization
does not compile aRichardsSimulation
anymore. Therefore, many source files are not compiled with--coverage
flags and don't appear in thegcovr
output at all. This artificially raises the Coverage. Not sure how to solve this.
Can this MR be accepted?
-
Implemented stuff -
Added unit tests -
[ ] Added system testNot required.test-parameterization-scaled
checks if scaling can be applied in context ofFlowParameters
. -
Merged master
into this branch -
Pipeline passing -
Added entry to CHANGELOG.md
Related issues
Closes #110 (closed), #18 (closed)