Skip to content

add extended miller scaling adapter

DUNE GitLab Responder requested to merge add-extendedMiller-ScalingAdapter into master

What does this MR do?

Implement an extended Miller scaling adapter, which additionally scales the porosity.

Edit: This also updates the testing of scaling fields by creating scaling fields for unit tests on the fly and specifically testing fields that are non-square. test-scaling-adapters and test-richards-param-scaled have been ported to Google Test and check for the new scaling adapter as well.

Is there something that needs to be double checked?

Is the underlying implementation of the scaling correct? Specifically: Does the mass balance hold?

Can this MR be accepted?

  • Implemented MilPorScalingAdapter
  • Added/Updated tests:
    • test-scaling-adapters
    • test-richards-param-scaled
  • Added/Updated documentation
    • Developer documentation (Doxygen)
    • User documentation (Sphinx)
  • Pipeline passing
  • Squash option set
  • Delete branch option set
  • Added entry to CHANGELOG.md

Assignee: If the Squash option is set, check/update the commit message right before merging!

Related issues

Edited by Lukas Riedel

Merge request reports