Skip to content

Implement new VTK file reader

Lukas Riedel requested to merge update-vtkreader into master

What does this MR do?

Add a more flexible, generic VTK XML file reader. The reader is based on the sketch in $16.

This reader is intended to replace the currently used dorie.VTKFile. This will likely require adapting the test cases, which should be done in a separate MR. Therefore, both readers will exist in parallel for now.

Still to-do:

  • Add a test for the file. Possibly use a file from the VTK Dataset repositories.
  • Improve docstrings and add object to user docs.
  • Rebuild new version of base image.

Is there something that needs to be double checked?

Can this MR be accepted?

  • Implemented new reader
  • Added test for testing new reader
  • Pipeline passing
  • Make CI variables protected again
  • Added entry to CHANGELOG.md

Related issues

Edited by Lukas Riedel

Merge request reports