Skip to content

Resolve "Add upwinding option to Richards FV solver"

Lukas Riedel requested to merge 153-add-upwinding-option-to-richards-fv-solver into master

What does this MR do?

Add upwinding options to the Richards FV local operator. The options are similar to the ones available from the DG operator and have the same names: none, semiUpwind (upwind conductivity factor), and fullUpwind (upwind entire conductivity)). The configuration setting EXPERIMENTAL_DG_SETTINGS has been removed. All settings are now available within the richards.numerics section and are always enabled.

The ODE tests have been adjusted to cover the upwinding cases where adjustment of the tolerance level was not necessary. This is the case for all upwinding schemes of FV. With the DG operator, none and semiUpwind work in homogeneous domains, and only none in heterogeneous (layered) domains. For more information, see https://ts-gitlab.iup.uni-heidelberg.de/dorie/dorie/merge_requests/161#note_34560

Additional changes:

  • Fix typo: Rename DG scheme OOB to OBB (Oden, Babuska, Baumann).

Is there something that needs to be double checked?

I guess not.

Can this MR be accepted?

  • Implemented upwinding options
  • Added test cases to ODE tests
  • Update README.md and docs
  • Pipeline passing
  • Added entry to CHANGELOG.md

Related issues

Closes #153 (closed)

Edited by Lukas Riedel

Merge request reports