Skip to content

Resolve "Make CFL condition the upper limit for time steps in explicit transport solver"

Lukas Riedel requested to merge 170-transport-model-must-distinguish-current-and-total-end-time into master

What does this MR do?

Instead of setting the new time step, the CFL condition now is a time step suggestion, which means that it serves as upper limit for the time step of the explicit transport solver.

The explicit time step scheme is now also covered by the test-model-coupling unit test.

Is there something that needs to be double checked?

No.

Can this MR be accepted?

  • Use suggest_time_step() with CFL condition limit
  • Added/Updated tests:
    • test-model-coupling: Check explicit time step scheme
  • [ ] Added/Updated documentation
  • Pipeline passing
  • Squash option set
  • Delete branch option set
  • Added entry to CHANGELOG.md

Assignee: If the Squash option is set, check/update the commit message right before merging!

Related issues

Closes #170 (closed)

Edited by Lukas Riedel

Merge request reports