Skip to content

Resolve "Flux reconstruction on FV does not work with alpha volumes"

What does this MR do?

Fixes Flux reconstruction engine to work with finite volume local operators that have alpha_volume methods.

Is there something that needs to be double checked?

  • Not sure how to test. I wouldn't add an alpha_volume method now if we are not using it.
  • Should volume assembly return immediately or just skip alpha_volume call? Not sure, have to check that computations in volume assembly does not affect other calls. It does not matter, the rest of the body is always skipped because FE order is 0.

Can this MR be accepted?

  • Implemented
  • Added/Updated tests:
  • Added/Updated documentation
  • Pipeline passing
  • Squash option set
  • Delete branch option set
  • Added entry to CHANGELOG.md

Assignee: If the Squash option is set, check/update the commit message right before merging!

Related issues

Closes #206 (closed)

Edited by Santiago Ospina De Los Ríos

Merge request reports